Re: [PATCH] Switch nfs/callback.c to using struct pid, not pid_t

2007-08-29 Thread Christoph Hellwig
On Wed, Aug 29, 2007 at 10:10:41AM -0400, Trond Myklebust wrote: > On Wed, 2007-08-29 at 14:52 +0100, Christoph Hellwig wrote: > > On Wed, Aug 29, 2007 at 05:36:24PM +0400, Pavel Emelyanov wrote: > > > Pid namespaces make it dangerous to use pid and tgid values > > > when run in some namespace. The

Re: [PATCH] Switch nfs/callback.c to using struct pid, not pid_t

2007-08-29 Thread Trond Myklebust
On Wed, 2007-08-29 at 14:52 +0100, Christoph Hellwig wrote: > On Wed, Aug 29, 2007 at 05:36:24PM +0400, Pavel Emelyanov wrote: > > Pid namespaces make it dangerous to use pid and tgid values > > when run in some namespace. The struct pid itself is going > > to be the only way for working with task

Re: [PATCH] Switch nfs/callback.c to using struct pid, not pid_t

2007-08-29 Thread Christoph Hellwig
On Wed, Aug 29, 2007 at 05:36:24PM +0400, Pavel Emelyanov wrote: > Pid namespaces make it dangerous to use pid and tgid values > when run in some namespace. The struct pid itself is going > to be the only way for working with task pids, so make the > nfs callback thread use it. > > Since nfs_callb

[PATCH] Switch nfs/callback.c to using struct pid, not pid_t

2007-08-29 Thread Pavel Emelyanov
Pid namespaces make it dangerous to use pid and tgid values when run in some namespace. The struct pid itself is going to be the only way for working with task pids, so make the nfs callback thread use it. Since nfs_callback_info.pid is set to current's one and reset on the thread exit, it is saf