On Tue, 30 Jan 2007 11:26:42 +0100
Rodolfo Giometti <[EMAIL PROTECTED]> wrote:
> > > +static int tsl2550_get_adc_value(struct i2c_client *client, int channel)
> > > +{
> > > + u8 cmd = channel == 0 ? TSL2550_READ_ADC0 : TSL2550_READ_ADC1;
> > > + int timeout, ret;
> > > +
> > > + /* Read ADC
On Mon, Jan 29, 2007 at 06:39:50PM -0800, Andrew Morton wrote:
> > +/* Insmod parameters */
> > +I2C_CLIENT_INSMOD_1(tsl2550);
> > +
> > +static int operating_mode = 0;
>
> The `= 0' is unneeded and undesirable.
Fixed.
> > ...
> >
> > +static int tsl2550_get_adc_value(struct i2c_client
On Mon, Jan 29, 2007 at 06:39:50PM -0800, Andrew Morton wrote:
+/* Insmod parameters */
+I2C_CLIENT_INSMOD_1(tsl2550);
+
+static int operating_mode = 0;
The `= 0' is unneeded and undesirable.
Fixed.
...
+static int tsl2550_get_adc_value(struct i2c_client *client, int channel)
On Tue, 30 Jan 2007 11:26:42 +0100
Rodolfo Giometti [EMAIL PROTECTED] wrote:
+static int tsl2550_get_adc_value(struct i2c_client *client, int channel)
+{
+ u8 cmd = channel == 0 ? TSL2550_READ_ADC0 : TSL2550_READ_ADC1;
+ int timeout, ret;
+
+ /* Read ADC channel waiting at most
On Mon, 29 Jan 2007 18:39:50 -0800
Andrew Morton <[EMAIL PROTECTED]> wrote:
> > attached a patch to add support for Taos TSL2550 ambient light sensors
> > (http://www.taosinc.com/product_detail.asp?cateid=4=18).
> >
>
> Some minor things:
Oh, and please send a signoff for this work as per
On Tue, 30 Jan 2007 00:56:19 +0100
Rodolfo Giometti <[EMAIL PROTECTED]> wrote:
> Hello,
>
> attached a patch to add support for Taos TSL2550 ambient light sensors
> (http://www.taosinc.com/product_detail.asp?cateid=4=18).
>
Some minor things:
> +#include
> +#include
> +#include
> +#include
Hello,
attached a patch to add support for Taos TSL2550 ambient light sensors
(http://www.taosinc.com/product_detail.asp?cateid=4=18).
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail:[EMAIL PROTECTED]
Linux Device Driver [EMAIL PROTECTED]
Embedded
Hello,
attached a patch to add support for Taos TSL2550 ambient light sensors
(http://www.taosinc.com/product_detail.asp?cateid=4proid=18).
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail:[EMAIL PROTECTED]
Linux Device Driver [EMAIL PROTECTED]
On Tue, 30 Jan 2007 00:56:19 +0100
Rodolfo Giometti [EMAIL PROTECTED] wrote:
Hello,
attached a patch to add support for Taos TSL2550 ambient light sensors
(http://www.taosinc.com/product_detail.asp?cateid=4proid=18).
Some minor things:
+#include linux/module.h
+#include linux/init.h
On Mon, 29 Jan 2007 18:39:50 -0800
Andrew Morton [EMAIL PROTECTED] wrote:
attached a patch to add support for Taos TSL2550 ambient light sensors
(http://www.taosinc.com/product_detail.asp?cateid=4proid=18).
Some minor things:
Oh, and please send a signoff for this work as per section
10 matches
Mail list logo