[PATCH] TTY: n_gsm, fix false positive WARN_ON

2016-03-22 Thread Jiri Slaby
Dmitry reported, that the current cleanup code in n_gsm can trigger a warning: WARNING: CPU: 2 PID: 24238 at drivers/tty/n_gsm.c:2048 gsm_cleanup_mux+0x166/0x6b0() ... Call Trace: ... [] warn_slowpath_null+0x29/0x30 kernel/panic.c:490 [] gsm_cleanup_mux+0x166/0x6b0 drivers/tty/n_gsm.c:2048 [] g

Re: [PATCH] TTY: n_gsm, fix false positive WARN_ON

2016-03-01 Thread Greg Kroah-Hartman
> >>> > >> >>> I think it would work, and the logic is correct. Or I just miss > >> >>> something important? > >> >> > >> >> > >> >> Yup, it looks like a cleanup. Could you prepare a separate patch for > >

Re: [PATCH] TTY: n_gsm, fix false positive WARN_ON

2016-03-01 Thread Dmitry Vyukov
are a separate patch for that? >> >> >> > yes, I will do that :) >> > >> >> Something like this: >> >> /* open failed before registering => nothing to do */ >> >> if (gsm_mux[gsm->num] != gsm) >> >>return; >> >> spin_lock(&gsm_mux_lock); >> >> gsm_mux[gsm->num] = NULL; >> >> spin_unlock(&gsm_mux_lock); >> >> >> > looks pretty good, thanks. >> >> >> This is still not merged and fires regularly for me. Can we please merge it? > > merge what? I don't see any patch here or in my queue for this :( "[PATCH] TTY: n_gsm, fix false positive WARN_ON" from Jiri Slaby: https://lkml.org/lkml/2015/11/24/600 FWIW I have it in my tree for 3 months. Warnings have gone. No issues noticed.

Re: [PATCH] TTY: n_gsm, fix false positive WARN_ON

2016-02-29 Thread Greg Kroah-Hartman
On Sun, Feb 28, 2016 at 05:16:15PM +0100, Dmitry Vyukov wrote: > On Wed, Nov 25, 2015 at 11:32 AM, xinhui wrote: > > hi, Jiri > > > > On 2015/11/25 17:56, Jiri Slaby wrote: > >> > >> Hi, > >> > >> On 11/25/2015, 07:32 AM, xinhui wrote: > >>> > >>> This warning should blame on commit 5a640967

Re: [PATCH] TTY: n_gsm, fix false positive WARN_ON

2016-02-28 Thread Dmitry Vyukov
On Wed, Nov 25, 2015 at 11:32 AM, xinhui wrote: > hi, Jiri > > On 2015/11/25 17:56, Jiri Slaby wrote: >> >> Hi, >> >> On 11/25/2015, 07:32 AM, xinhui wrote: >>> >>> This warning should blame on commit 5a640967 ("tty/n_gsm.c: fix a >>> memory leak in gsmld_open()"). >> >> >> Oh, yes, I messed

Re: [PATCH] TTY: n_gsm, fix false positive WARN_ON

2015-11-25 Thread xinhui
hi, Jiri On 2015/11/25 17:56, Jiri Slaby wrote: Hi, On 11/25/2015, 07:32 AM, xinhui wrote: This warning should blame on commit 5a640967 ("tty/n_gsm.c: fix a memory leak in gsmld_open()"). Oh, yes, I messed up the "Fixes" line then. It should write: Fixes: 5a640967 ("tty/n_gsm.c: fix a m

Re: [PATCH] TTY: n_gsm, fix false positive WARN_ON

2015-11-25 Thread Jiri Slaby
Hi, On 11/25/2015, 07:32 AM, xinhui wrote: > This warning should blame on commit 5a640967 ("tty/n_gsm.c: fix a > memory leak in gsmld_open()"). Oh, yes, I messed up the "Fixes" line then. It should write: Fixes: 5a640967 ("tty/n_gsm.c: fix a memory leak in gsmld_open()") > I have one confusi

Re: [PATCH] TTY: n_gsm, fix false positive WARN_ON

2015-11-24 Thread xinhui
hi, Jiri This warning should blame on commit 5a640967 ("tty/n_gsm.c: fix a memory leak in gsmld_open()"). When gsm driver failed to activate one mux,there is memory leak. So I call this ->cleanup() to do the cleanup work. Seems I did not consider all cases. I have one confusion. As ther

[PATCH] TTY: n_gsm, fix false positive WARN_ON

2015-11-24 Thread Jiri Slaby
Dmitry reported, that the current cleanup code in n_gsm can trigger a warning: WARNING: CPU: 2 PID: 24238 at drivers/tty/n_gsm.c:2048 gsm_cleanup_mux+0x166/0x6b0() ... Call Trace: ... [] warn_slowpath_null+0x29/0x30 kernel/panic.c:490 [] gsm_cleanup_mux+0x166/0x6b0 drivers/tty/n_gsm.c:2048 [] g