Re: [PATCH] Tty: serial - Fix possible NULL derefrence.

2017-02-18 Thread Greg Kroah-Hartman
On Sat, Feb 18, 2017 at 11:25:19AM +0100, Maarten Brock wrote: > Hello Greg, > > Does that also mean that this isn't possible in the sc16is7xx.c driver in > sc16is7xx_spi_probe() line 1358 and sc16is7xx_i2c_probe() line 1419 ? > > If so, should these checks be removed? Probably.

Re: [PATCH] Tty: serial - Fix possible NULL derefrence.

2017-02-18 Thread Maarten Brock
Hello Greg, Does that also mean that this isn't possible in the sc16is7xx.c driver in sc16is7xx_spi_probe() line 1358 and sc16is7xx_i2c_probe() line 1419 ? If so, should these checks be removed? Kind regards, Maarten On 2017-01-30 20:37, Greg Kroah-Hartman wrote: On Fri, Jan 27, 2017 at 04:

Re: [PATCH] Tty: serial - Fix possible NULL derefrence.

2017-01-30 Thread Greg Kroah-Hartman
On Fri, Jan 27, 2017 at 04:46:13PM +0530, Shailendra Verma wrote: > of_match_device could return NULL, and so can cause a NULL > pointer dereference later. > > Signed-off-by: Shailendra Verma > --- > drivers/tty/serial/max310x.c |4 > 1 file changed, 4 insertions(+) > > diff --git a/dr

Re: [PATCH] Tty: serial - Fix possible NULL derefrence.

2017-01-27 Thread Greg Kroah-Hartman
On Fri, Jan 27, 2017 at 04:46:13PM +0530, Shailendra Verma wrote: > of_match_device could return NULL, and so can cause a NULL > pointer dereference later. > > Signed-off-by: Shailendra Verma > --- > drivers/tty/serial/max310x.c |4 > 1 file changed, 4 insertions(+) > > diff --git a/dr

[PATCH] Tty: serial - Fix possible NULL derefrence.

2017-01-27 Thread Shailendra Verma
of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/tty/serial/max310x.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c index 8a3e926..a94d147 100