Re: [PATCH] UAPI linux/fs.h: add a warning about wrong ioctl argument types

2013-11-27 Thread Aurelien Jarno
On Wed, Nov 27, 2013 at 03:13:40AM -0800, Christoph Hellwig wrote: > Thanks Aurelien, > > the added comment looks good and very useful, > > Reviewed-by: Christoph Hellwig > Thanks for the review. > We don't have any man pages documenting these ioctls or other user > visible documentation, do

Re: [PATCH] UAPI linux/fs.h: add a warning about wrong ioctl argument types

2013-11-27 Thread Christoph Hellwig
Thanks Aurelien, the added comment looks good and very useful, Reviewed-by: Christoph Hellwig We don't have any man pages documenting these ioctls or other user visible documentation, do we? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[PATCH] UAPI linux/fs.h: add a warning about wrong ioctl argument types

2013-11-27 Thread Aurelien Jarno
The FS_IOC_GETFLAGS, FS_IOC_SETFLAGS, FS_IOC_GETVERSION and FS_IOC_SETVERSION ioctls are declared for historical reasons with a long argument, while in practice they take an int argument. This is unfortunately not possible to fix that without breaking the kernel ABI. However good programmers actua