Re: [PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Jeff Dike
On Fri, Sep 28, 2007 at 11:26:34AM -0700, Andrew Morton wrote: > Doesn't this assume that the arch is only ever uniprocessor, which I > don't think is true on i386 UML?? It is for now, and when that changes, I haven't decided if and when interrupts will be received on multiple CPUs.

Re: [PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Andrew Morton
On Fri, 28 Sep 2007 11:43:14 -0400 Jeff Dike <[EMAIL PROTECTED]> wrote: > Add _irqsave/_irqrestore to the locking in update_drop_skb to keep > uml_net_rx out while the drop skb is being messed with. > > Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> > --- > arch/um/drivers/net_kern.c |5 +++--

[PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Jeff Dike
Add _irqsave/_irqrestore to the locking in update_drop_skb to keep uml_net_rx out while the drop skb is being messed with. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/drivers/net_kern.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index:

[PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Jeff Dike
Add _irqsave/_irqrestore to the locking in update_drop_skb to keep uml_net_rx out while the drop skb is being messed with. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/drivers/net_kern.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Index:

Re: [PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Andrew Morton
On Fri, 28 Sep 2007 11:43:14 -0400 Jeff Dike [EMAIL PROTECTED] wrote: Add _irqsave/_irqrestore to the locking in update_drop_skb to keep uml_net_rx out while the drop skb is being messed with. Signed-off-by: Jeff Dike [EMAIL PROTECTED] --- arch/um/drivers/net_kern.c |5 +++-- 1 file

Re: [PATCH] UML - Fix locking in skb alloction failure fix

2007-09-28 Thread Jeff Dike
On Fri, Sep 28, 2007 at 11:26:34AM -0700, Andrew Morton wrote: Doesn't this assume that the arch is only ever uniprocessor, which I don't think is true on i386 UML?? It is for now, and when that changes, I haven't decided if and when interrupts will be received on multiple CPUs.