Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-13 Thread Felipe Balbi
On Wed, Feb 13, 2008 at 01:36:00PM -0800, David Brownell wrote: > On Wednesday 13 February 2008, Felipe Balbi wrote: > > On Tue, Feb 12, 2008 at 12:32:34PM -0800, David Brownell wrote: > > > > > > Your proposal is to strike the "is_b_host" check. In terms of the > > > OTG (1.3) state machine,

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-13 Thread David Brownell
On Wednesday 13 February 2008, Felipe Balbi wrote: > On Tue, Feb 12, 2008 at 12:32:34PM -0800, David Brownell wrote: > > > > Your proposal is to strike the "is_b_host" check. In terms of the > > OTG (1.3) state machine, that removes a b_host --> b_peripheral > > state transition. > > Not at

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-13 Thread Felipe Balbi
On Tue, Feb 12, 2008 at 12:32:34PM -0800, David Brownell wrote: > > > > > > Some devices claim > > > > > > to be b_host even though they have an a_connector attached to it. > > > > > > > > > > Why not just fix that bug? Remember that's Linux code. > > > > > > > > The device claiming to be

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-13 Thread David Brownell
On Wednesday 13 February 2008, Felipe Balbi wrote: On Tue, Feb 12, 2008 at 12:32:34PM -0800, David Brownell wrote: Your proposal is to strike the is_b_host check. In terms of the OTG (1.3) state machine, that removes a b_host -- b_peripheral state transition. Not at all, we're just

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-13 Thread Felipe Balbi
On Wed, Feb 13, 2008 at 01:36:00PM -0800, David Brownell wrote: On Wednesday 13 February 2008, Felipe Balbi wrote: On Tue, Feb 12, 2008 at 12:32:34PM -0800, David Brownell wrote: Your proposal is to strike the is_b_host check. In terms of the OTG (1.3) state machine, that removes a

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread David Brownell
> > > > > Some devices claim > > > > > to be b_host even though they have an a_connector attached to it. > > > > > > > > Why not just fix that bug? Remember that's Linux code. > > > > > > The device claiming to be b_host is not linux based. > > > > Wrong ... the meaning of that flag is:

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread Felipe Balbi
On Tue, Feb 12, 2008 at 05:02:47AM -0800, David Brownell wrote: > On Tuesday 12 February 2008, Felipe Balbi wrote: > > On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote: > > > On Tuesday 12 February 2008, Felipe Balbi wrote: > > > > Some devices claim > > > > to be b_host even though

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread David Brownell
On Tuesday 12 February 2008, Felipe Balbi wrote: > On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote: > > On Tuesday 12 February 2008, Felipe Balbi wrote: > > > Some devices claim > > > to be b_host even though they have an a_connector attached to it. > > > > Why not just fix that

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread Felipe Balbi
On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote: > On Tuesday 12 February 2008, Felipe Balbi wrote: > > Some devices claim > > to be b_host even though they have an a_connector attached to it. > > Why not just fix that bug? Remember that's Linux code. The device claiming to be

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread David Brownell
On Tuesday 12 February 2008, Felipe Balbi wrote: > Some devices claim > to be b_host even though they have an a_connector attached to it. Why not just fix that bug? Remember that's Linux code. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread Felipe Balbi
Remove the check for is_b_host upon enumerating otg devices as it can trigger some weird behaviors on otg sessions. Some devices claim to be b_host even though they have an a_connector attached to it. Checking b_hnp_enable flag should be secure enough or terms of otg compliancy. Signed-off-by:

[PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread Felipe Balbi
Remove the check for is_b_host upon enumerating otg devices as it can trigger some weird behaviors on otg sessions. Some devices claim to be b_host even though they have an a_connector attached to it. Checking b_hnp_enable flag should be secure enough or terms of otg compliancy. Signed-off-by:

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread David Brownell
Some devices claim to be b_host even though they have an a_connector attached to it. Why not just fix that bug? Remember that's Linux code. The device claiming to be b_host is not linux based. Wrong ... the meaning of that flag is: *THIS* system is a Linux-USB

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread Felipe Balbi
On Tue, Feb 12, 2008 at 05:02:47AM -0800, David Brownell wrote: On Tuesday 12 February 2008, Felipe Balbi wrote: On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote: On Tuesday 12 February 2008, Felipe Balbi wrote: Some devices claim to be b_host even though they have an

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread David Brownell
On Tuesday 12 February 2008, Felipe Balbi wrote: On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote: On Tuesday 12 February 2008, Felipe Balbi wrote: Some devices claim to be b_host even though they have an a_connector attached to it. Why not just fix that bug? Remember

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread Felipe Balbi
On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote: On Tuesday 12 February 2008, Felipe Balbi wrote: Some devices claim to be b_host even though they have an a_connector attached to it. Why not just fix that bug? Remember that's Linux code. The device claiming to be b_host is

Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

2008-02-12 Thread David Brownell
On Tuesday 12 February 2008, Felipe Balbi wrote: Some devices claim to be b_host even though they have an a_connector attached to it. Why not just fix that bug? Remember that's Linux code. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to