[RESEND PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2015-01-09 Thread Nicolas Ferre
From: Songjun Wu When unloading the module 'g_hid.ko', the urb request will be dequeued and the completion routine will be excuted. If there is no urb packet, the urb request will not be added to the endpoint queue and the completion routine pointer in urb request is NULL. Accessing to this NULL

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2015-01-08 Thread Felipe Balbi
Hi, On Tue, Dec 30, 2014 at 05:49:27PM +0800, Songjun Wu wrote: > Executing the 'insmod g_hid.ko', then executing the > 'rmmod g_hid.ko', the NULL pointer oops will be triggered. > > When unloading the module 'g_hid.ko', the urb request will be > dequeued and the completion routine will be excute

[PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-30 Thread Songjun Wu
Executing the 'insmod g_hid.ko', then executing the 'rmmod g_hid.ko', the NULL pointer oops will be triggered. When unloading the module 'g_hid.ko', the urb request will be dequeued and the completion routine will be excuted. If no urb packet, the urb request will not be added to the endpoint queu

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-29 Thread Felipe Balbi
Hi, On Mon, Dec 29, 2014 at 05:42:01PM +0800, Wu, Songjun wrote: > > > On 12/26/2014 23:27, Felipe Balbi wrote: > >Hi, > > > >On Wed, Dec 24, 2014 at 09:14:53AM +0800, Wu, Songjun wrote: > >> > >>在 12/24/2014 00:24, Felipe Balbi 写道: > >>>On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-29 Thread Wu, Songjun
On 12/26/2014 23:27, Felipe Balbi wrote: Hi, On Wed, Dec 24, 2014 at 09:14:53AM +0800, Wu, Songjun wrote: 在 12/24/2014 00:24, Felipe Balbi 写道: On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: When unloading the module, the urb request will be dequeued and the completion routine

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-29 Thread Wu, Songjun
On 12/26/2014 23:27, Felipe Balbi wrote: Hi, On Wed, Dec 24, 2014 at 09:14:53AM +0800, Wu, Songjun wrote: 在 12/24/2014 00:24, Felipe Balbi 写道: On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: When unloading the module, the urb request will be dequeued and the completion routine

看看这样回复可以吗? Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-29 Thread Wu, Songjun
On 12/26/2014 23:27, Felipe Balbi wrote: Hi, On Wed, Dec 24, 2014 at 09:14:53AM +0800, Wu, Songjun wrote: 在 12/24/2014 00:24, Felipe Balbi 写道: On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: When unloading the module, the urb request will be dequeued and the completion routine

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-26 Thread Felipe Balbi
Hi, On Wed, Dec 24, 2014 at 09:14:53AM +0800, Wu, Songjun wrote: > > 在 12/24/2014 00:24, Felipe Balbi 写道: > >On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: > >>When unloading the module, the urb request will be dequeued > >>and the completion routine will be excuted. > >>If no urb pa

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-23 Thread Wu, Songjun
在 12/24/2014 00:24, Felipe Balbi 写道: On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: When unloading the module, the urb request will be dequeued and the completion routine will be excuted. If no urb packet, the urb request will not be added to the endpoint queue and the completion r

Re: [PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-23 Thread Felipe Balbi
On Mon, Dec 22, 2014 at 05:26:14PM +0800, Songjun Wu wrote: > When unloading the module, the urb request will be dequeued > and the completion routine will be excuted. > If no urb packet, the urb request will not be added to the endpoint queue > and the completion routine pointer in urb request is

[PATCH] USB: gadget: udc: atmel: fix possible oops when unloading module

2014-12-22 Thread Songjun Wu
When unloading the module, the urb request will be dequeued and the completion routine will be excuted. If no urb packet, the urb request will not be added to the endpoint queue and the completion routine pointer in urb request is NULL. Accessing to the NULL function pointer will cause the oops iss