usb_autopm_put_interface() should be called regardless of what
idmouse_create_image() returns.

Signed-off-by: Junjie Mao <junjie....@enight.me>
---
 drivers/usb/misc/idmouse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/misc/idmouse.c b/drivers/usb/misc/idmouse.c
index 4e38683c653c..5105397e62fc 100644
--- a/drivers/usb/misc/idmouse.c
+++ b/drivers/usb/misc/idmouse.c
@@ -257,9 +257,9 @@ static int idmouse_open(struct inode *inode, struct file 
*file)
                if (result)
                        goto error;
                result = idmouse_create_image (dev);
+               usb_autopm_put_interface(interface);
                if (result)
                        goto error;
-               usb_autopm_put_interface(interface);
 
                /* increment our usage count for the driver */
                ++dev->open;
-- 
1.9.3

Reply via email to