Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Alan Stern
On Tue, 18 Jun 2013, Felipe Balbi wrote: > yeah, Roger brought up a big problem with OMAP's EHCI depending on the > mode so, at least for now, we should keep phy_get and, in case of EHCI > OMAP, phy_init in the glue :-( > > Roger has all the details, and they're also in the list archives, but > b

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 10:53:26AM -0400, Alan Stern wrote: > > > If the controllers don't want HCD core to manage the PHY they can just > > > set it > > > to some error code. > > > > they shouldn't have the choice, otherwise it'll be a bit of a PITA to > > maintain the code. ehci core tries

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Alan Stern
On Tue, 18 Jun 2013, Felipe Balbi wrote: > HI, > > On Tue, Jun 18, 2013 at 11:23:59AM +0300, Roger Quadros wrote: > > On 06/18/2013 11:01 AM, Felipe Balbi wrote: > > > Hi, > > > > > > On Tue, Jun 18, 2013 at 03:15:01AM -0400, Chao Xie wrote: > > >> Some controller need software to initialize PHY

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Chao Xie
On Tue, Jun 18, 2013 at 4:48 PM, Felipe Balbi wrote: > Hi, > > On Tue, Jun 18, 2013 at 11:45:05AM +0300, Roger Quadros wrote: >> > this looks wrong for two reasons: >> > >> > a) you're not grabbing the PHY here. >> > >> > You can't just assume another entity grabbed you

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 11:45:05AM +0300, Roger Quadros wrote: > > this looks wrong for two reasons: > > > > a) you're not grabbing the PHY here. > > > > You can't just assume another entity grabbed your PHY for you. > > Isn't that done in the controller d

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Roger Quadros
On 06/18/2013 11:37 AM, Felipe Balbi wrote: > Hi, > > On Tue, Jun 18, 2013 at 11:34:08AM +0300, Roger Quadros wrote: > On Tue, Jun 18, 2013 at 03:15:01AM -0400, Chao Xie wrote: >> Some controller need software to initialize PHY before add >> host controller, and shut down PHY after rem

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 11:34:08AM +0300, Roger Quadros wrote: > >>> On Tue, Jun 18, 2013 at 03:15:01AM -0400, Chao Xie wrote: > Some controller need software to initialize PHY before add > host controller, and shut down PHY after remove host controller. > Add the generic code f

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Roger Quadros
On 06/18/2013 11:24 AM, Felipe Balbi wrote: > HI, > > On Tue, Jun 18, 2013 at 11:23:59AM +0300, Roger Quadros wrote: >> On 06/18/2013 11:01 AM, Felipe Balbi wrote: >>> Hi, >>> >>> On Tue, Jun 18, 2013 at 03:15:01AM -0400, Chao Xie wrote: Some controller need software to initialize PHY before

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Roger Quadros
On 06/18/2013 11:01 AM, Felipe Balbi wrote: > Hi, > > On Tue, Jun 18, 2013 at 03:15:01AM -0400, Chao Xie wrote: >> Some controller need software to initialize PHY before add >> host controller, and shut down PHY after remove host controller. >> Add the generic code for these controllers so they do

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Felipe Balbi
HI, On Tue, Jun 18, 2013 at 11:23:59AM +0300, Roger Quadros wrote: > On 06/18/2013 11:01 AM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Jun 18, 2013 at 03:15:01AM -0400, Chao Xie wrote: > >> Some controller need software to initialize PHY before add > >> host controller, and shut down PHY after

Re: [PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 03:15:01AM -0400, Chao Xie wrote: > Some controller need software to initialize PHY before add > host controller, and shut down PHY after remove host controller. > Add the generic code for these controllers so they do not need > do it in its own host controller driver.

[PATCH] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Chao Xie
Some controller need software to initialize PHY before add host controller, and shut down PHY after remove host controller. Add the generic code for these controllers so they do not need do it in its own host controller driver. Signed-off-by: Chao Xie --- drivers/usb/core/hcd.c | 19 ++