Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-19 Thread Johan Hovold
On Tue, Dec 19, 2017 at 07:14:17AM +0100, Bjørn Mork wrote: > "SZ Lin (林上智)" writes: > >> Johan Hovold writes: > >> > >> >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { > >> >> + .reserved = BIT(0) | BIT(1) | BIT(4), }; > >> > > >> > Do you really need to blackl

Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-18 Thread Bjørn Mork
"SZ Lin (林上智)" writes: >> Johan Hovold writes: >> >> >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { >> >> + .reserved = BIT(0) | BIT(1) | BIT(4), }; >> > >> > Do you really need to blacklist the first interface? >> >> Good question. Interface #0 does look a lot like

RE: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-18 Thread 林上智
] USB: serial: option: adding support for YUGA CLM920-NC5 > > Johan Hovold writes: > > >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { > >> + .reserved = BIT(0) | BIT(1) | BIT(4), }; > > > > Do you really need to blacklist the first

Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-18 Thread Bjørn Mork
Johan Hovold writes: >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { >> +.reserved = BIT(0) | BIT(1) | BIT(4), >> +}; > > Do you really need to blacklist the first interface? Good question. Interface #0 does look a lot like a Qualcomm DM/DIAG function, based on tw

Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-18 Thread Johan Hovold
[ +CC: Bjørn ] On Fri, Dec 15, 2017 at 06:32:03PM +0800, SZ Lin wrote: > This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to option > driver. Could you specify what each interface is used for here? > Signed-off-by: Taiyi Wu > Signed-off-by: SZ Lin Is SZ your legal name? > ---

[PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

2017-12-15 Thread SZ Lin
This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to option driver. Signed-off-by: Taiyi Wu Signed-off-by: SZ Lin --- Please refer to following lsusb output: Bus 001 Device 003: ID 05c6:9625 Qualcomm, Inc. Device Descriptor: bLength18 bDescriptorType