Re: [PATCH] Use fall-through attribute rather than magic comments

On Tue 2019-06-18 02:30:35, Joe Perches wrote: > On Tue, 2019-06-18 at 09:34 +0200, Pavel Machek wrote: > > On Mon 2019-06-17 09:25:56, Joe Perches wrote: > > > On Mon, 2019-06-17 at 17:56 +0200, Pavel Machek wrote: > > > > Hi! > > > > > > > > > +/* > > > > > + * gcc: > > > > > https://gcc.gnu.

Re: [PATCH] Use fall-through attribute rather than magic comments

On Tue, 2019-06-18 at 09:34 +0200, Pavel Machek wrote: > On Mon 2019-06-17 09:25:56, Joe Perches wrote: > > On Mon, 2019-06-17 at 17:56 +0200, Pavel Machek wrote: > > > Hi! > > > > > > > +/* > > > > + * gcc: > > > > https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthr

Re: [PATCH] Use fall-through attribute rather than magic comments

On Mon 2019-06-17 09:25:56, Joe Perches wrote: > On Mon, 2019-06-17 at 17:56 +0200, Pavel Machek wrote: > > Hi! > > > > > +/* > > > + * gcc: > > > https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough > > > + * gcc: > > > https://developers.redhat.com/blog/2017/

RE: [PATCH] Use fall-through attribute rather than magic comments

From: Joe Perches > Sent: 17 June 2019 17:26 > On Mon, 2019-06-17 at 17:56 +0200, Pavel Machek wrote: > > Hi! > > > > > +/* > > > + * gcc: > > > https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough > > > + * gcc: > > > https://developers.redhat.com/blog/2017/03/

Re: [PATCH] Use fall-through attribute rather than magic comments

On Mon, 2019-06-17 at 17:56 +0200, Pavel Machek wrote: > Hi! > > > +/* > > + * gcc: > > https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough > > + * gcc: > > https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/ > > + */ > > +#if __has_a

Re: [PATCH] Use fall-through attribute rather than magic comments

Hi! > +/* > + * gcc: > https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough > + * gcc: > https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/ > + */ > +#if __has_attribute(__fallthrough__) > +# define __fallthrough__

Re: [PATCH] Use fall-through attribute rather than magic comments

Hi Shawn, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.1-rc1] [cannot apply to next-20190319] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://gi

Re: [PATCH] Use fall-through attribute rather than magic comments

Hi Shawn, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.1-rc1] [cannot apply to next-20190318] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH] Use fall-through attribute rather than magic comments

Hi Shawn, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.1-rc1] [cannot apply to next-20190318] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://gi

Re: [PATCH] Use fall-through attribute rather than magic comments

Shawn, On 3/15/19 10:38 PM, Shawn Landden wrote: > The -Wimplicit-fallthrough warning recognizes magic comments > https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/ > It is my opinion that magic comments are a bad idea. Comments should not > change the interpretation (ev

Re: [PATCH] Use fall-through attribute rather than magic comments

On Fri, 2019-03-15 at 21:38 -0600, Shawn Landden wrote: > The -Wimplicit-fallthrough warning recognizes magic comments > https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/ > It is my opinion that magic comments are a bad idea. Comments should not > change the interpretati