Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-22 Thread Russell King
On Tue, Jan 22, 2008 at 01:17:15PM -0800, Greg KH wrote: > I like this a lot. It makes things much more understandable from a > driver developer's point of view, and would allow us to mark some things > as freeable when we do not run with a CPU hotplug system :) You mean at run time - I'm not

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-22 Thread Greg KH
On Sun, Jan 20, 2008 at 09:09:03PM +0100, Sam Ravnborg wrote: > Introducing separate sections for __dev* (HOTPLUG), > __cpu* (HOTPLUG_CPU) and __mem* (MEMORY_HOTPLUG) > allows us to do a much more reliable Section mismatch > check in modpost. We are no longer dependent on the actual >

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-22 Thread Greg KH
On Sun, Jan 20, 2008 at 09:09:03PM +0100, Sam Ravnborg wrote: Introducing separate sections for __dev* (HOTPLUG), __cpu* (HOTPLUG_CPU) and __mem* (MEMORY_HOTPLUG) allows us to do a much more reliable Section mismatch check in modpost. We are no longer dependent on the actual configuration of

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-22 Thread Russell King
On Tue, Jan 22, 2008 at 01:17:15PM -0800, Greg KH wrote: I like this a lot. It makes things much more understandable from a driver developer's point of view, and would allow us to mark some things as freeable when we do not run with a CPU hotplug system :) You mean at run time - I'm not sure

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Sam Ravnborg
On Tue, Jan 22, 2008 at 09:56:57AM +0900, Paul Mundt wrote: > On Mon, Jan 21, 2008 at 01:06:41PM +0100, Sam Ravnborg wrote: > > On Mon, Jan 21, 2008 at 07:52:57PM +0900, Paul Mundt wrote: > > > On Mon, Jan 21, 2008 at 11:47:45AM +0100, Sam Ravnborg wrote: > > > > On Mon, Jan 21, 2008 at 11:45:06AM

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Paul Mundt
On Mon, Jan 21, 2008 at 01:06:41PM +0100, Sam Ravnborg wrote: > On Mon, Jan 21, 2008 at 07:52:57PM +0900, Paul Mundt wrote: > > On Mon, Jan 21, 2008 at 11:47:45AM +0100, Sam Ravnborg wrote: > > > On Mon, Jan 21, 2008 at 11:45:06AM +0100, Sam Ravnborg wrote: > > > > On Mon, Jan 21, 2008 at

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 07:52:57PM +0900, Paul Mundt wrote: > On Mon, Jan 21, 2008 at 11:47:45AM +0100, Sam Ravnborg wrote: > > On Mon, Jan 21, 2008 at 11:45:06AM +0100, Sam Ravnborg wrote: > > > On Mon, Jan 21, 2008 at 11:29:52AM +0100, Andreas Schwab wrote: > > > > Sam Ravnborg <[EMAIL

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Paul Mundt
On Mon, Jan 21, 2008 at 11:47:45AM +0100, Sam Ravnborg wrote: > On Mon, Jan 21, 2008 at 11:45:06AM +0100, Sam Ravnborg wrote: > > On Mon, Jan 21, 2008 at 11:29:52AM +0100, Andreas Schwab wrote: > > > Sam Ravnborg <[EMAIL PROTECTED]> writes: > > > > > > > On Mon, Jan 21, 2008 at 04:33:41PM +0900,

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 11:45:06AM +0100, Sam Ravnborg wrote: > On Mon, Jan 21, 2008 at 11:29:52AM +0100, Andreas Schwab wrote: > > Sam Ravnborg <[EMAIL PROTECTED]> writes: > > > > > On Mon, Jan 21, 2008 at 04:33:41PM +0900, Paul Mundt wrote: > > >> so the ## is being taken directly rather than

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 11:29:52AM +0100, Andreas Schwab wrote: > Sam Ravnborg <[EMAIL PROTECTED]> writes: > > > On Mon, Jan 21, 2008 at 04:33:41PM +0900, Paul Mundt wrote: > >> so the ## is being taken directly rather than acting as a concatenation. > > > > Strange... > > I can reproduce with

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Andreas Schwab
Sam Ravnborg <[EMAIL PROTECTED]> writes: > On Mon, Jan 21, 2008 at 04:33:41PM +0900, Paul Mundt wrote: >> so the ## is being taken directly rather than acting as a concatenation. > > Strange... > I can reproduce with gcc 3.4.5 here - will fix. The ## operator does not work with -traditional.

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 04:33:41PM +0900, Paul Mundt wrote: > On Sun, Jan 20, 2008 at 09:09:03PM +0100, Sam Ravnborg wrote: > > diff --git a/include/asm-generic/vmlinux.lds.h > > b/include/asm-generic/vmlinux.lds.h > > index ded7ca2..e0a56fb 100644 > > --- a/include/asm-generic/vmlinux.lds.h > >

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 04:33:41PM +0900, Paul Mundt wrote: On Sun, Jan 20, 2008 at 09:09:03PM +0100, Sam Ravnborg wrote: diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index ded7ca2..e0a56fb 100644 --- a/include/asm-generic/vmlinux.lds.h +++

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Andreas Schwab
Sam Ravnborg [EMAIL PROTECTED] writes: On Mon, Jan 21, 2008 at 04:33:41PM +0900, Paul Mundt wrote: so the ## is being taken directly rather than acting as a concatenation. Strange... I can reproduce with gcc 3.4.5 here - will fix. The ## operator does not work with -traditional. Andreas.

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 11:29:52AM +0100, Andreas Schwab wrote: Sam Ravnborg [EMAIL PROTECTED] writes: On Mon, Jan 21, 2008 at 04:33:41PM +0900, Paul Mundt wrote: so the ## is being taken directly rather than acting as a concatenation. Strange... I can reproduce with gcc 3.4.5 here -

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 11:45:06AM +0100, Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 11:29:52AM +0100, Andreas Schwab wrote: Sam Ravnborg [EMAIL PROTECTED] writes: On Mon, Jan 21, 2008 at 04:33:41PM +0900, Paul Mundt wrote: so the ## is being taken directly rather than acting as a

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Paul Mundt
On Mon, Jan 21, 2008 at 11:47:45AM +0100, Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 11:45:06AM +0100, Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 11:29:52AM +0100, Andreas Schwab wrote: Sam Ravnborg [EMAIL PROTECTED] writes: On Mon, Jan 21, 2008 at 04:33:41PM +0900, Paul Mundt

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Sam Ravnborg
On Mon, Jan 21, 2008 at 07:52:57PM +0900, Paul Mundt wrote: On Mon, Jan 21, 2008 at 11:47:45AM +0100, Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 11:45:06AM +0100, Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 11:29:52AM +0100, Andreas Schwab wrote: Sam Ravnborg [EMAIL PROTECTED] writes:

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Paul Mundt
On Mon, Jan 21, 2008 at 01:06:41PM +0100, Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 07:52:57PM +0900, Paul Mundt wrote: On Mon, Jan 21, 2008 at 11:47:45AM +0100, Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 11:45:06AM +0100, Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 11:29:52AM +0100,

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-21 Thread Sam Ravnborg
On Tue, Jan 22, 2008 at 09:56:57AM +0900, Paul Mundt wrote: On Mon, Jan 21, 2008 at 01:06:41PM +0100, Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 07:52:57PM +0900, Paul Mundt wrote: On Mon, Jan 21, 2008 at 11:47:45AM +0100, Sam Ravnborg wrote: On Mon, Jan 21, 2008 at 11:45:06AM +0100,

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-20 Thread Paul Mundt
On Sun, Jan 20, 2008 at 09:09:03PM +0100, Sam Ravnborg wrote: > diff --git a/include/asm-generic/vmlinux.lds.h > b/include/asm-generic/vmlinux.lds.h > index ded7ca2..e0a56fb 100644 > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -9,10 +9,46 @@ > /* Align

[PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-20 Thread Sam Ravnborg
Introducing separate sections for __dev* (HOTPLUG), __cpu* (HOTPLUG_CPU) and __mem* (MEMORY_HOTPLUG) allows us to do a much more reliable Section mismatch check in modpost. We are no longer dependent on the actual configuration of for example HOTPLUG. This has the effect that all users see much

[PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-20 Thread Sam Ravnborg
Introducing separate sections for __dev* (HOTPLUG), __cpu* (HOTPLUG_CPU) and __mem* (MEMORY_HOTPLUG) allows us to do a much more reliable Section mismatch check in modpost. We are no longer dependent on the actual configuration of for example HOTPLUG. This has the effect that all users see much

Re: [PATCH] Use separate sections for __dev/__cpu/__mem code/data

2008-01-20 Thread Paul Mundt
On Sun, Jan 20, 2008 at 09:09:03PM +0100, Sam Ravnborg wrote: diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index ded7ca2..e0a56fb 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -9,10 +9,46 @@ /* Align . to a