Re: [PATCH] VFS: Add back check for !inode in walk_component()

2015-05-08 Thread Steven Rostedt
On Thu, 7 May 2015 18:02:50 -0400 Steven Rostedt wrote: > It booted. Now I'm running my tests on it. Seems to survive. > > I'll reboot without it and see how long it takes to crash, and then > I'll make sure that it can survive at least 10x that time. > > I may not report back till tomorrow (u

Re: [PATCH] VFS: Add back check for !inode in walk_component()

2015-05-07 Thread Steven Rostedt
On Thu, 7 May 2015 22:47:55 +0100 Al Viro wrote: > On Thu, May 07, 2015 at 03:33:21PM -0400, Steven Rostedt wrote: > > On Thu, 7 May 2015 19:43:43 +0100 > > Al Viro wrote: > > > > > > > Actually, could you try the following on top of -rc2? > > > > Gives me the following on boot up: > > Gah..

Re: [PATCH] VFS: Add back check for !inode in walk_component()

2015-05-07 Thread Al Viro
On Thu, May 07, 2015 at 03:33:21PM -0400, Steven Rostedt wrote: > On Thu, 7 May 2015 19:43:43 +0100 > Al Viro wrote: > > > > Actually, could you try the following on top of -rc2? > > Gives me the following on boot up: Gah... Sorry, I'm an idiot - *path is left uninitialized in that case. Fix

Re: [PATCH] VFS: Add back check for !inode in walk_component()

2015-05-07 Thread Steven Rostedt
On Thu, 7 May 2015 19:43:43 +0100 Al Viro wrote: > Actually, could you try the following on top of -rc2? Gives me the following on boot up: [ cut here ] WARNING: CPU: 2 PID: 2920 at /home/rostedt/work/git/linux-trace.git/kernel/locking/lockdep.c:973 __bfs+0x112/0x1d5(

Re: [PATCH] VFS: Add back check for !inode in walk_component()

2015-05-07 Thread Steven Rostedt
On Thu, 7 May 2015 19:13:35 +0100 Al Viro wrote: > On Thu, May 07, 2015 at 01:39:35PM -0400, Steven Rostedt wrote: > > I had them printed in my previous traces. The flags were 0x200088, and > > they were 0 just before the call. > > Not dentry->d_flags, nd->flags. Most interesting part is bit 6

Re: [PATCH] VFS: Add back check for !inode in walk_component()

2015-05-07 Thread Al Viro
On Thu, May 07, 2015 at 07:13:35PM +0100, Al Viro wrote: > On Thu, May 07, 2015 at 01:39:35PM -0400, Steven Rostedt wrote: > > I had them printed in my previous traces. The flags were 0x200088, and > > they were 0 just before the call. > > Not dentry->d_flags, nd->flags. Most interesting part is

Re: [PATCH] VFS: Add back check for !inode in walk_component()

2015-05-07 Thread Al Viro
On Thu, May 07, 2015 at 01:39:35PM -0400, Steven Rostedt wrote: > I had them printed in my previous traces. The flags were 0x200088, and > they were 0 just before the call. Not dentry->d_flags, nd->flags. Most interesting part is bit 6 in those (LOOKUP_RCU, 0x40). As for creation... I think I s

Re: [PATCH] VFS: Add back check for !inode in walk_component()

2015-05-07 Thread Steven Rostedt
On Thu, 7 May 2015 13:39:35 -0400 Steven Rostedt wrote: > On Thu, 7 May 2015 18:28:34 +0100 > Al Viro wrote: > > > On Thu, May 07, 2015 at 12:52:41PM -0400, Steven Rostedt wrote: > > > > > > Commit 698934df8b45 "VFS: Combine inode checks with d_is_negative() and > > > d_is_positive() in pathwa

Re: [PATCH] VFS: Add back check for !inode in walk_component()

2015-05-07 Thread Steven Rostedt
On Thu, 7 May 2015 18:28:34 +0100 Al Viro wrote: > On Thu, May 07, 2015 at 12:52:41PM -0400, Steven Rostedt wrote: > > > > Commit 698934df8b45 "VFS: Combine inode checks with d_is_negative() and > > d_is_positive() in pathwalk" removed a check for inode being NULL in > > walk_component() where t

Re: [PATCH] VFS: Add back check for !inode in walk_component()

2015-05-07 Thread Al Viro
On Thu, May 07, 2015 at 12:52:41PM -0400, Steven Rostedt wrote: > > Commit 698934df8b45 "VFS: Combine inode checks with d_is_negative() and > d_is_positive() in pathwalk" removed a check for inode being NULL in > walk_component() where the type is tested. Stressing my tracefs create > and remove i

[PATCH] VFS: Add back check for !inode in walk_component()

2015-05-07 Thread Steven Rostedt
Commit 698934df8b45 "VFS: Combine inode checks with d_is_negative() and d_is_positive() in pathwalk" removed a check for inode being NULL in walk_component() where the type is tested. Stressing my tracefs create and remove instances while reading the files now triggers this: BUG: unable to handle