On Tue, 2015-07-07 at 22:08 -0400, valdis.kletni...@vt.edu wrote:
> On Tue, 07 Jul 2015 13:38:47 -0700, Joe Perches said:
>
> > The longest line in this file is 158 chars, that's
> > probably excessive, awk shows 35 lines > 80 chars.
>
> That doesn't count tabs. Checkpatch throws 98 warnings.
Y
On Tue, 07 Jul 2015 13:38:47 -0700, Joe Perches said:
> The longest line in this file is 158 chars, that's
> probably excessive, awk shows 35 lines > 80 chars.
That doesn't count tabs. Checkpatch throws 98 warnings.
pgpRav2SIlbke.pgp
Description: PGP signature
On Tue, 07 Jul 2015 21:08:10 -0400, Sreenath Madasu said:
> The kernelnewbies.org guide said "For your first patch, only pick one
> warning". That is the reason why I fixed one warning.
They mean "don't fix lines over 80 characters *and* missing-blank
warnings in the same patch".
pgpMmWKYBIEA7.p
The kernelnewbies.org guide said "For your first patch, only pick one
warning". That is the reason why I fixed one warning.
Thanks
Sreenath
On Tue, Jul 07, 2015 at 03:32:50PM -0400, valdis.kletni...@vt.edu wrote:
> On Mon, 06 Jul 2015 21:53:26 -0400, Sreenath Madasu said:
> > When the checkpatch.p
On Tue, 2015-07-07 at 15:32 -0400, valdis.kletni...@vt.edu wrote:
> All: Is it time to kill that checkpatch test, or hide it behind a non-default
> flag, to prevent code churn?
I'm not an 80 column zealot.
This is for staging isn't it?
Code churn there is expected and somewhat desired.
A lot o
On Mon, 06 Jul 2015 21:53:26 -0400, Sreenath Madasu said:
> When the checkpatch.pl script was run, it showed lines with length
> more than 80 characters in rtw_ap.c file. Fixed line number 382 by
> breaking it up into two lines within 80 characters.
> - stainfo_offset
On Mon, Jul 06, 2015 at 09:53:26PM -0400, Sreenath Madasu wrote:
> When the checkpatch.pl script was run, it showed lines with length
> more than 80 characters in rtw_ap.c file. Fixed line number 382 by
> breaking it up into two lines within 80 characters.
>
> Signed-off-by: Sreenath Madasu
> ---
When the checkpatch.pl script was run, it showed lines with length
more than 80 characters in rtw_ap.c file. Fixed line number 382 by
breaking it up into two lines within 80 characters.
Signed-off-by: Sreenath Madasu
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 3 ++-
1 file changed, 2 insertio
8 matches
Mail list logo