Re: [PATCH] WorkStruct: Fix S390 driver workstruct usage

2006-12-09 Thread Martin Schwidefsky
On Fri, 2006-12-08 at 17:33 +, Al Viro wrote: > I don't think it's a real fix. > > a) what protects tty from disappearing? Nothing.. > b) why the hell do we need that schedule_work() at all? handle_sysrq() is > supposed to be safe to use from irq handler; when needed it does arrange for > d

Re: [PATCH] WorkStruct: Fix S390 driver workstruct usage

2006-12-08 Thread Al Viro
On Fri, Dec 08, 2006 at 05:33:43PM +, Al Viro wrote: [snip] my apologies if that got sent more than once ;-/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: [PATCH] WorkStruct: Fix S390 driver workstruct usage

2006-12-08 Thread Al Viro
On Fri, Dec 08, 2006 at 02:59:40PM +, David Howells wrote: > diff --git a/drivers/s390/char/ctrlchar.c b/drivers/s390/char/ctrlchar.c > index 49e9628..9fcfe3a 100644 > --- a/drivers/s390/char/ctrlchar.c > +++ b/drivers/s390/char/ctrlchar.c > @@ -15,15 +15,16 @@ #include > #include "ctrlchar.

Re: [PATCH] WorkStruct: Fix S390 driver workstruct usage

2006-12-08 Thread Martin Schwidefsky
On Fri, 2006-12-08 at 14:59 +, David Howells wrote: > Fix S390 driver workstruct reduction problems. Bad timing. I just created similar patch and pushed it to git390. The only part it does not cover is the ctrlchar.c part. I hope you didn't spent too much time on this. -- blue skies, Marti

[PATCH] WorkStruct: Fix S390 driver workstruct usage

2006-12-08 Thread David Howells
Fix S390 driver workstruct reduction problems. Signed-Off-By: David Howells <[EMAIL PROTECTED]> --- drivers/s390/char/ctrlchar.c |9 + drivers/s390/char/tape.h |3 ++- drivers/s390/char/tape_34xx.c | 26 -- drivers/s390/char/tape_block.c | 13