Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-28 Thread Dmitri Vorobiev
Ingo Molnar пишет: > * Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: > >> Paolo Ciarrocchi пишет: >>> On Jan 27, 2008 11:48 PM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote: On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: >> ... >>> How should I compare the .o file? >>> Simply doi

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-28 Thread Ingo Molnar
* Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: > Paolo Ciarrocchi пишет: > > On Jan 27, 2008 11:48 PM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote: > >> On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > ... > > > > How should I compare the .o file? > > Simply doing a md5sum or shou

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Dmitri Vorobiev
Paolo Ciarrocchi пишет: > On Jan 27, 2008 11:48 PM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote: >> On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: ... > > How should I compare the .o file? > Simply doing a md5sum or should I do a objdump -d before? > Or a strip? > Comparing the

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Paolo Ciarrocchi
On Jan 27, 2008 11:48 PM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote: > > On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > * Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: > > > > > Looks like it would be better to proceed in the following manner: > > > > > > 1) remove dead code

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Paolo Ciarrocchi
On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: > > > Looks like it would be better to proceed in the following manner: > > > > 1) remove dead code (no md5 change); > > 2) reformat the lines to use tabs, not spaces (no md5 change); >

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Ingo Molnar
* Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: > Looks like it would be better to proceed in the following manner: > > 1) remove dead code (no md5 change); > 2) reformat the lines to use tabs, not spaces (no md5 change); > 3) address the "else-braces" and "single statement block" errors >(no m

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Paolo Ciarrocchi
On Jan 27, 2008 11:32 PM, Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: [..] > > Is there any point in changing code inside the #if 0/#endif block? Just to avoid checkpatch complaints :-) > > @@ -76,10 +74,10 @@ void Un_impl(void) > > /* > > Called for opcodes which are illegal and which are kn

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Dmitri Vorobiev
Paolo Ciarrocchi пишет: > This file has not been modified since October so should be > easy to integrate the following patch. > > Before: > total: 214 errors, 28 warnings, 739 lines checked > > After: > total: 4 errors, 28 warnings, 708 lines checked > > Compile tested: > > [EMAIL PROTECTED]:/

[PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Paolo Ciarrocchi
This file has not been modified since October so should be easy to integrate the following patch. Before: total: 214 errors, 28 warnings, 739 lines checked After: total: 4 errors, 28 warnings, 708 lines checked Compile tested: [EMAIL PROTECTED]:/tmp$ size error.o.* textdata bss