Re: [PATCH] __get_cpu_var should use __smp_processor_id() not smp_processor_id()

2005-01-17 Thread Chris Wedgwood
On Mon, Jan 17, 2005 at 03:40:16PM +0100, Ingo Molnar wrote: > no ... normally you should only use __get_cpu_var() if you know that > you are in a non-preempt case. It's a __ internal function for a > reason. Where did it trigger? XFS has statistics which are 'per cpu' but doesn't use per_cpu

Re: [PATCH] __get_cpu_var should use __smp_processor_id() not smp_processor_id()

2005-01-17 Thread Ingo Molnar
* Chris Wedgwood <[EMAIL PROTECTED]> wrote: > It seems logical that __get_cpu_var should use __smp_processor_id() > rather than smp_processor_id(). Noticed when __get_cpu_var was making > lots of noise with CONFIG_DEBUG_PREEMPT=y no ... normally you should only use __get_cpu_var() if you know

Re: [PATCH] __get_cpu_var should use __smp_processor_id() not smp_processor_id()

2005-01-17 Thread Ingo Molnar
* Chris Wedgwood [EMAIL PROTECTED] wrote: It seems logical that __get_cpu_var should use __smp_processor_id() rather than smp_processor_id(). Noticed when __get_cpu_var was making lots of noise with CONFIG_DEBUG_PREEMPT=y no ... normally you should only use __get_cpu_var() if you know that

Re: [PATCH] __get_cpu_var should use __smp_processor_id() not smp_processor_id()

2005-01-17 Thread Chris Wedgwood
On Mon, Jan 17, 2005 at 03:40:16PM +0100, Ingo Molnar wrote: no ... normally you should only use __get_cpu_var() if you know that you are in a non-preempt case. It's a __ internal function for a reason. Where did it trigger? XFS has statistics which are 'per cpu' but doesn't use per_cpu

[PATCH] __get_cpu_var should use __smp_processor_id() not smp_processor_id()

2005-01-16 Thread Chris Wedgwood
On Sun, Jan 16, 2005 at 09:50:44PM -0800, Chris Wedgwood wrote: > Note, even with this removed I'm still seeing a few (many actually) > "BUG: using smp_processor_id() in preemptible [0001] code: xxx" > messages which I've not seen before --- that might be unrelated but > I do see *many* such

[PATCH] __get_cpu_var should use __smp_processor_id() not smp_processor_id()

2005-01-16 Thread Chris Wedgwood
On Sun, Jan 16, 2005 at 09:50:44PM -0800, Chris Wedgwood wrote: Note, even with this removed I'm still seeing a few (many actually) BUG: using smp_processor_id() in preemptible [0001] code: xxx messages which I've not seen before --- that might be unrelated but I do see *many* such