RE: [Devel] [PATCH] acpi: set return value to const char for some functions

2015-10-21 Thread Moore, Robert
19, 2015 10:16 AM > To: LABBE Corentin > Cc: Wysocki, Rafael J; linux-kernel@vger.kernel.org; linux- > a...@vger.kernel.org; LABBE Corentin; de...@acpica.org > Subject: Re: [Devel] [PATCH] acpi: set return value to const char for some > functions > > You may have missed this,

RE: [PATCH] acpi: set return value to const char for some functions

2015-10-19 Thread Moore, Robert
From: Moore, Robert > Sent: Monday, October 19, 2015 10:05 AM > To: 'LABBE Corentin' > Cc: LABBE Corentin; Zheng, Lv; Wysocki, Rafael J; l...@kernel.org; linux- > a...@vger.kernel.org; de...@acpica.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH] acpi: set return v

RE: [PATCH] acpi: set return value to const char for some functions

2015-10-19 Thread Moore, Robert
19, 2015 5:03 AM > To: Moore, Robert > Cc: LABBE Corentin; Zheng, Lv; Wysocki, Rafael J; l...@kernel.org; linux- > a...@vger.kernel.org; de...@acpica.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] acpi: set return value to const char for some > functions > > On W

Re: [PATCH] acpi: set return value to const char for some functions

2015-10-19 Thread LABBE Corentin
m] > > Sent: Wednesday, October 14, 2015 12:07 PM > > To: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; l...@kernel.org > > Cc: linux-a...@vger.kernel.org; de...@acpica.org; linux- > > ker...@vger.kernel.org; LABBE Corentin > > Subject: [PATCH] acpi: set return value to con

Re: [PATCH] acpi: set return value to const char for some functions

2015-10-15 Thread Joe Perches
On Fri, 2015-10-16 at 03:37 +, Moore, Robert wrote: > If you don't like the quote, just stick with my first assessment. Thanks, but if you can't make arguments yourself, it seems you're making assertions rather than assessments. -- To unsubscribe from this list: send the line "unsubscribe li

RE: [PATCH] acpi: set return value to const char for some functions

2015-10-15 Thread Moore, Robert
rnel.org; linux- > a...@vger.kernel.org; de...@acpica.org; linux-kernel@vger.kernel.org; Box, > David E > Subject: Re: [PATCH] acpi: set return value to const char for some > functions > > On Thu, 2015-10-15 at 19:32 +, Moore, Robert wrote: > > if you started to use "const&quo

Re: [PATCH] acpi: set return value to const char for some functions

2015-10-15 Thread Joe Perches
On Thu, 2015-10-15 at 19:32 +, Moore, Robert wrote: > if you started to use "const" for some methods you usually forced to > use this in most of your code. But the time spent for maintaining > (typing, recompiling when some const is missing, etc.) of > const-correctness in code seems greater th

RE: [PATCH] acpi: set return value to const char for some functions

2015-10-15 Thread Moore, Robert
> Please describe the effects of "const pollution". > > Why isn't it useful to update the functions that don't modify function > pointer arguments to const? It's not that const isn't useful, but it can create problems, especially in existing code. It can bubble up to higher functions, causing lo

Re: [PATCH] acpi: set return value to const char for some functions

2015-10-14 Thread Joe Perches
On Wed, 2015-10-14 at 20:53 +, Moore, Robert wrote: > In ACPICA, we tend to be very careful concerning the "const" keyword in order > to avoid a phenomenon known as "const pollution". > > That is not to say that we won't use const in some limited cases. Please describe the effects of "const

RE: [PATCH] acpi: set return value to const char for some functions

2015-10-14 Thread Moore, Robert
abbe.montj...@gmail.com] > Sent: Wednesday, October 14, 2015 12:07 PM > To: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; l...@kernel.org > Cc: linux-a...@vger.kernel.org; de...@acpica.org; linux- > ker...@vger.kernel.org; LABBE Corentin > Subject: [PATCH] acpi: set return value to con

Re: [PATCH] acpi: set return value to const char for some functions

2015-10-14 Thread kbuild test robot
Hi LABBE, [auto build test ERROR on pm/linux-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/LABBE-Corentin/acpi-set-return-value-to-const-char-for-some-functions/20151015-030935 config: i386-randcon

[PATCH] acpi: set return value to const char for some functions

2015-10-14 Thread LABBE Corentin
This patch set some array of const char as const. In the same time, some function return pointer to thoses array without properly giving the information that the data is const. This patch set the return type of thoses functions as const char * Signed-off-by: LABBE Corentin --- drivers/acpi/acpic