Re: [PATCH] acpica: Fix double-free in acpi_ns_repair_CID()

2017-02-06 Thread Daniel Drake
On Mon, Feb 6, 2017 at 8:46 AM, João Paulo Rechi Vita wrote: > Yes, the real problem is i2c_hid not being probed for the touchpad > device on this platform The lack of probe was because when i2c_acpi_add_device() called acpi_bus_get_device() on the handle for the touchpad device (TPL1), it was re

RE: [PATCH] acpica: Fix double-free in acpi_ns_repair_CID()

2017-02-05 Thread Zheng, Lv
ces). > > Bob > > > > From: João Paulo Rechi Vita [mailto:jprv...@gmail.com] > > Subject: [PATCH] acpica: Fix double-free in acpi_ns_repair_CID() > > > > When acpi_ns_repair_CID() is called for a _CID which returns a package of > > strings, it calls acpi_ns_repa

RE: [PATCH] acpica: Fix double-free in acpi_ns_repair_CID()

2017-02-03 Thread Moore, Robert
y, February 03, 2017 12:57 PM > To: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; Lin Ming > Cc: linux-a...@vger.kernel.org; de...@acpica.org; linux- > ker...@vger.kernel.org; Daniel Drake; li...@endlessm.com; João Paulo Rechi > Vita > Subject: [PATCH] acpica: Fix doub

[PATCH] acpica: Fix double-free in acpi_ns_repair_CID()

2017-02-03 Thread João Paulo Rechi Vita
When acpi_ns_repair_CID() is called for a _CID which returns a package of strings, it calls acpi_ns_repair_HID() for each of the package elements. acpi_ns_repair_HID() calls acpi_ut_remove_reference() on the original object, but acpi_ns_repair_CID() calls it again on return, leading to a double fr