Re: [PATCH] add chan->cl check in mbox_chan_received_data()

2021-02-03 Thread Yao Haidong
Oh, I see, thank you 2021-02-01 14:28 GMT+08:00, Jassi Brar : > On Thu, Jan 7, 2021 at 5:53 AM haidong yao wrote: >> >> Hi Jassi Brar >> >> Thank you very much for your reply. >> >> Look at the function sprd_mbox_outbox_isr . >> >> Chan is !NULL. >> >> chan->cl is NULL when the client driver

Re: [PATCH] add chan->cl check in mbox_chan_received_data()

2021-01-31 Thread Jassi Brar
On Thu, Jan 7, 2021 at 5:53 AM haidong yao wrote: > > Hi Jassi Brar > > Thank you very much for your reply. > > Look at the function sprd_mbox_outbox_isr . > > Chan is !NULL. > > chan->cl is NULL when the client driver not loaded, the controller > driver don't know the client driver loaded

Re: [PATCH] add chan->cl check in mbox_chan_received_data()

2021-01-07 Thread haidong yao
Hi Jassi Brar Thank you very much for your reply. Look at the function sprd_mbox_outbox_isr . Chan is !NULL. chan->cl is NULL when the client driver not loaded, the controller driver don't know the client driver loaded successfully, so, I do not use mbox_free_channel. Here,How do you know

Re: [PATCH] add chan->cl check in mbox_chan_received_data()

2020-12-15 Thread Orson Zhai
On Tue, Dec 15, 2020 at 4:48 PM Haidong Yao wrote: > > From: Haidong Yao > > mailbox outbox irq is coming, but mbox_request_channel > is not be registered, so cl->rx_callback is NULL. Both "chan->cl" and "chan->cl->rx_callback" should be checked for being NULL. > > panic log: > [

Re: [PATCH] add chan->cl check in mbox_chan_received_data()

2020-12-15 Thread Jassi Brar
On Tue, Dec 15, 2020 at 2:48 AM Haidong Yao wrote: > --- a/drivers/mailbox/mailbox.c > +++ b/drivers/mailbox/mailbox.c > @@ -152,7 +152,7 @@ static enum hrtimer_restart txdone_hrtimer(struct hrtimer > *hrtimer) > void mbox_chan_received_data(struct mbox_chan *chan, void *mssg) > { >

[PATCH] add chan->cl check in mbox_chan_received_data()

2020-12-15 Thread Haidong Yao
From: Haidong Yao mailbox outbox irq is coming, but mbox_request_channel is not be registered, so cl->rx_callback is NULL. panic log: [9.852090]c0 Unable to handle kernel NULL pointer dereference at virtual address 0020 [9.954634]c0 pstate: 60400089 (nZCv daIf +PAN -UAO)