Re: [PATCH] add stricmp

2005-09-08 Thread viro
On Thu, Sep 08, 2005 at 05:37:13PM +0100, Alan Cox wrote: > On Iau, 2005-09-08 at 17:45 +0200, Jan Beulich wrote: > > >The only general, usable strnicmp safe for general kernel use would be > > a > > >full all singing all dancing UTF-8 symbol aware arbitary locale > > >implementation. And that we *

Re: [PATCH] add stricmp

2005-09-08 Thread Alan Cox
On Iau, 2005-09-08 at 17:45 +0200, Jan Beulich wrote: > >The only general, usable strnicmp safe for general kernel use would be > a > >full all singing all dancing UTF-8 symbol aware arbitary locale > >implementation. And that we *definitely* do not want in kernel. > > Then you'd want to immediate

Re: [PATCH] add stricmp

2005-09-08 Thread Alan Cox
On Iau, 2005-09-08 at 17:28 +0200, Jan Beulich wrote: > Then how am I supposed to do ASCII-only case-insensitive compares (i.e. > reading config files)? And why is there a strnicmp? If this is not going There is no such thing as "ascii" for case sensitivity. The case and ordering rules are locale

Re: [PATCH] add stricmp

2005-09-08 Thread Christoph Hellwig
On Thu, Sep 08, 2005 at 05:28:19PM +0200, Jan Beulich wrote: > Then how am I supposed to do ASCII-only case-insensitive compares (i.e. > reading config files)? You're not supposed to read config files in the kernel, nevermind case-insensitive ones. If you want things case-insensitive please stay

Re: [PATCH] add stricmp

2005-09-08 Thread Jan Beulich
>The only general, usable strnicmp safe for general kernel use would be a >full all singing all dancing UTF-8 symbol aware arbitary locale >implementation. And that we *definitely* do not want in kernel. Then you'd want to immediately get rid of the mentioned, pre-exisiting strnicmp(). Jan - To u

Re: [PATCH] add stricmp

2005-09-08 Thread Jan Beulich
>>> Christoph Hellwig <[EMAIL PROTECTED]> 08.09.05 17:17:54 >>> >On Thu, Sep 08, 2005 at 05:05:06PM +0200, Jan Beulich wrote: >> (Note: Patch also attached because the inline version is certain to get >> line wrapped.) >> >> While strnicmp existed in the set of string support routines, stricmp >>

Re: [PATCH] add stricmp

2005-09-08 Thread Christoph Hellwig
On Thu, Sep 08, 2005 at 05:05:06PM +0200, Jan Beulich wrote: > (Note: Patch also attached because the inline version is certain to get > line wrapped.) > > While strnicmp existed in the set of string support routines, stricmp > didn't, which this patch adjusts. I don't thing we should do case-ins

[PATCH] add stricmp

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) While strnicmp existed in the set of string support routines, stricmp didn't, which this patch adjusts. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/include/linux/string.h 2.6.13-stricmp/in