Re: [tpmdd-devel] [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Kent Yoder
On Thu, Nov 8, 2012 at 9:36 AM, Fioravante, Matthew E. wrote: >> >>> On 07.11.12 at 19:14, Matthew Fioravante >> >>> wrote: >> > On 11/07/2012 09:46 AM, Kent Yoder wrote: >> >>> --- a/drivers/char/tpm/tpm.h >> >>> +++ b/drivers/char/tpm/tpm.h >> >>> @@ -130,6 +130,9 @@ struct tpm_chip { >> >>>

RE: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Fioravante, Matthew E.
-kernel@vger.kernel.org Subject: Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver On Wed, Nov 07, 2012 at 09:05:26AM -0500, Matthew Fioravante wrote: > On 11/06/2012 02:39 PM, Konrad Rzeszutek Wilk wrote: > >On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fiorava

RE: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Fioravante, Matthew E.
-kernel@vger.kernel.org; m...@srajiv.net; tpmdd-de...@lists.sourceforge.net Subject: Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver On Thu, Nov 08, 2012 at 08:17:32AM +, Jan Beulich wrote: > >>> On 07.11.12 at 19:14, Matthew Fioravante > >>

Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Kent Yoder
On Thu, Nov 08, 2012 at 08:17:32AM +, Jan Beulich wrote: > >>> On 07.11.12 at 19:14, Matthew Fioravante > >>> wrote: > > On 11/07/2012 09:46 AM, Kent Yoder wrote: > >>> --- a/drivers/char/tpm/tpm.h > >>> +++ b/drivers/char/tpm/tpm.h > >>> @@ -130,6 +130,9 @@ struct tpm_chip { > >>> > >>>

Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Konrad Rzeszutek Wilk
On Thu, Nov 08, 2012 at 09:46:16AM +0100, Ian Campbell wrote: > > > >>+typedef struct tpmif_tx_request tpmif_tx_request_t; > > > > checkpatch warned on this new typedef - please run through checkpatch > > > >and fix up that stuff. > > > tpmif.h has a couple of typedefs which do trigger

Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Ian Campbell
> > >>+typedef struct tpmif_tx_request tpmif_tx_request_t; > > > checkpatch warned on this new typedef - please run through checkpatch > > >and fix up that stuff. > > tpmif.h has a couple of typedefs which do trigger checkpatch > > warnings. However it looks like the paradigm for xen is to have

Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Jan Beulich
>>> On 07.11.12 at 19:14, Matthew Fioravante >>> wrote: > On 11/07/2012 09:46 AM, Kent Yoder wrote: >>> --- a/drivers/char/tpm/tpm.h >>> +++ b/drivers/char/tpm/tpm.h >>> @@ -130,6 +130,9 @@ struct tpm_chip { >>> >>> struct list_head list; >>> void (*release) (struct device *); >>> +#if

Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Jan Beulich
On 07.11.12 at 19:14, Matthew Fioravante matthew.fiorava...@jhuapl.edu wrote: On 11/07/2012 09:46 AM, Kent Yoder wrote: --- a/drivers/char/tpm/tpm.h +++ b/drivers/char/tpm/tpm.h @@ -130,6 +130,9 @@ struct tpm_chip { struct list_head list; void (*release) (struct device *); +#if

Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Ian Campbell
+typedef struct tpmif_tx_request tpmif_tx_request_t; checkpatch warned on this new typedef - please run through checkpatch and fix up that stuff. tpmif.h has a couple of typedefs which do trigger checkpatch warnings. However it looks like the paradigm for xen is to have these

Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Konrad Rzeszutek Wilk
On Thu, Nov 08, 2012 at 09:46:16AM +0100, Ian Campbell wrote: +typedef struct tpmif_tx_request tpmif_tx_request_t; checkpatch warned on this new typedef - please run through checkpatch and fix up that stuff. tpmif.h has a couple of typedefs which do trigger checkpatch warnings.

Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Kent Yoder
On Thu, Nov 08, 2012 at 08:17:32AM +, Jan Beulich wrote: On 07.11.12 at 19:14, Matthew Fioravante matthew.fiorava...@jhuapl.edu wrote: On 11/07/2012 09:46 AM, Kent Yoder wrote: --- a/drivers/char/tpm/tpm.h +++ b/drivers/char/tpm/tpm.h @@ -130,6 +130,9 @@ struct tpm_chip {

RE: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Fioravante, Matthew E.
-kernel@vger.kernel.org; m...@srajiv.net; tpmdd-de...@lists.sourceforge.net Subject: Re: [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver On Thu, Nov 08, 2012 at 08:17:32AM +, Jan Beulich wrote: On 07.11.12 at 19:14, Matthew Fioravante matthew.fiorava...@jhuapl.edu

RE: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Fioravante, Matthew E.
-kernel@vger.kernel.org Subject: Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver On Wed, Nov 07, 2012 at 09:05:26AM -0500, Matthew Fioravante wrote: On 11/06/2012 02:39 PM, Konrad Rzeszutek Wilk wrote: On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: This patch

Re: [tpmdd-devel] [Xen-devel] [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-08 Thread Kent Yoder
On Thu, Nov 8, 2012 at 9:36 AM, Fioravante, Matthew E. matthew.fiorava...@jhuapl.edu wrote: On 07.11.12 at 19:14, Matthew Fioravante matthew.fiorava...@jhuapl.edu wrote: On 11/07/2012 09:46 AM, Kent Yoder wrote: --- a/drivers/char/tpm/tpm.h +++ b/drivers/char/tpm/tpm.h @@ -130,6

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Konrad Rzeszutek Wilk
On Wed, Nov 07, 2012 at 01:14:25PM -0500, Matthew Fioravante wrote: > On 11/07/2012 09:46 AM, Kent Yoder wrote: > >Hi Matthew, > > > >On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: > >>This patch ports the xen vtpm frontend driver for linux > >>from the linux-2.6.18-xen.hg

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Matthew Fioravante
On 11/07/2012 09:46 AM, Kent Yoder wrote: Hi Matthew, On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: This patch ports the xen vtpm frontend driver for linux from the linux-2.6.18-xen.hg tree to linux-stable. Signed-off-by: Matthew Fioravante ---

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Konrad Rzeszutek Wilk
On Wed, Nov 07, 2012 at 09:05:26AM -0500, Matthew Fioravante wrote: > On 11/06/2012 02:39 PM, Konrad Rzeszutek Wilk wrote: > >On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: > >>This patch ports the xen vtpm frontend driver for linux > >>from the linux-2.6.18-xen.hg tree to

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Kent Yoder
> >>+static struct attribute *vtpm_attrs[] = { > >>+ _attr_pubek.attr, > >>+ _attr_pcrs.attr, > >>+ _attr_enabled.attr, > >>+ _attr_active.attr, > >>+ _attr_owned.attr, > >>+ _attr_temp_deactivated.attr, > >>+ _attr_caps.attr, > >>+ _attr_cancel.attr, > >>+

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Kent Yoder
Hi Matthew, On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: > This patch ports the xen vtpm frontend driver for linux > from the linux-2.6.18-xen.hg tree to linux-stable. > > Signed-off-by: Matthew Fioravante > --- > drivers/char/tpm/Kconfig |9 + >

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Matthew Fioravante
On 11/06/2012 02:39 PM, Konrad Rzeszutek Wilk wrote: On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: This patch ports the xen vtpm frontend driver for linux from the linux-2.6.18-xen.hg tree to linux-stable. So how does on test it ? Set it up? Use it? Is there some

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Matthew Fioravante
On 11/06/2012 02:39 PM, Konrad Rzeszutek Wilk wrote: On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: This patch ports the xen vtpm frontend driver for linux from the linux-2.6.18-xen.hg tree to linux-stable. So how does on test it ? Set it up? Use it? Is there some

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Kent Yoder
Hi Matthew, On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: This patch ports the xen vtpm frontend driver for linux from the linux-2.6.18-xen.hg tree to linux-stable. Signed-off-by: Matthew Fioravante matthew.fiorava...@jhuapl.edu --- drivers/char/tpm/Kconfig |

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Kent Yoder
+static struct attribute *vtpm_attrs[] = { + dev_attr_pubek.attr, + dev_attr_pcrs.attr, + dev_attr_enabled.attr, + dev_attr_active.attr, + dev_attr_owned.attr, + dev_attr_temp_deactivated.attr, + dev_attr_caps.attr, + dev_attr_cancel.attr, + NULL, So

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Konrad Rzeszutek Wilk
On Wed, Nov 07, 2012 at 09:05:26AM -0500, Matthew Fioravante wrote: On 11/06/2012 02:39 PM, Konrad Rzeszutek Wilk wrote: On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: This patch ports the xen vtpm frontend driver for linux from the linux-2.6.18-xen.hg tree to

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Matthew Fioravante
On 11/07/2012 09:46 AM, Kent Yoder wrote: Hi Matthew, On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: This patch ports the xen vtpm frontend driver for linux from the linux-2.6.18-xen.hg tree to linux-stable. Signed-off-by: Matthew Fioravante matthew.fiorava...@jhuapl.edu

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-07 Thread Konrad Rzeszutek Wilk
On Wed, Nov 07, 2012 at 01:14:25PM -0500, Matthew Fioravante wrote: On 11/07/2012 09:46 AM, Kent Yoder wrote: Hi Matthew, On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: This patch ports the xen vtpm frontend driver for linux from the linux-2.6.18-xen.hg tree to

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-06 Thread Konrad Rzeszutek Wilk
On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: > This patch ports the xen vtpm frontend driver for linux > from the linux-2.6.18-xen.hg tree to linux-stable. So how does on test it ? Set it up? Use it? Is there some documentation about it - if so it should be in the patch

Re: [PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-06 Thread Konrad Rzeszutek Wilk
On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote: This patch ports the xen vtpm frontend driver for linux from the linux-2.6.18-xen.hg tree to linux-stable. So how does on test it ? Set it up? Use it? Is there some documentation about it - if so it should be in the patch

[PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-05 Thread Matthew Fioravante
This patch ports the xen vtpm frontend driver for linux from the linux-2.6.18-xen.hg tree to linux-stable. Signed-off-by: Matthew Fioravante --- drivers/char/tpm/Kconfig |9 + drivers/char/tpm/Makefile|2 + drivers/char/tpm/tpm.h | 15 +

[PATCH] add tpm_xenu.ko: Xen Virtual TPM frontend driver

2012-11-05 Thread Matthew Fioravante
This patch ports the xen vtpm frontend driver for linux from the linux-2.6.18-xen.hg tree to linux-stable. Signed-off-by: Matthew Fioravante matthew.fiorava...@jhuapl.edu --- drivers/char/tpm/Kconfig |9 + drivers/char/tpm/Makefile|2 + drivers/char/tpm/tpm.h |