Re: [PATCH] add transport class symlink to device object

2005-08-31 Thread Dmitry Torokhov
On Wednesday 31 August 2005 16:43, Greg KH wrote: > On Thu, Aug 18, 2005 at 02:50:19PM -0500, Dmitry Torokhov wrote: > > On 8/18/05, Greg KH <[EMAIL PROTECTED]> wrote: > > > @@ -500,9 +519,13 @@ int class_device_add(struct class_device > > >} > > > > > >class_device_add_attrs(class

Re: [PATCH] add transport class symlink to device object

2005-08-31 Thread Greg KH
On Thu, Aug 18, 2005 at 02:50:19PM -0500, Dmitry Torokhov wrote: > On 8/18/05, Greg KH <[EMAIL PROTECTED]> wrote: > > @@ -500,9 +519,13 @@ int class_device_add(struct class_device > >} > > > >class_device_add_attrs(class_dev); > > - if (class_dev->dev) > > + if (class_d

Re: [PATCH] add transport class symlink to device object

2005-08-18 Thread Dmitry Torokhov
On 8/18/05, Greg KH <[EMAIL PROTECTED]> wrote: > @@ -500,9 +519,13 @@ int class_device_add(struct class_device >} > >class_device_add_attrs(class_dev); > - if (class_dev->dev) > + if (class_dev->dev) { > + class_name = make_class_name(class_dev); >

Re: [PATCH] add transport class symlink to device object

2005-08-18 Thread Matthew Wilcox
On Thu, Aug 18, 2005 at 12:04:42AM -0700, Greg KH wrote: > Matthew, this work for you? Yep, that's fine by me. Thanks. -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will

RE: [PATCH] add transport class symlink to device object

2005-08-18 Thread James . Smart
thew Wilcox; Smart, James; Andrew Morton; SCSI Mailing List; > Linux Kernel; Alan Cox; Russell King; Dmitry Torokhov > Subject: Re: [PATCH] add transport class symlink to device object > > > On Wed, Aug 17, 2005 at 10:23:11PM -0700, Greg KH wrote: > > On Mon, Aug 15, 2

RE: [PATCH] add transport class symlink to device object

2005-08-18 Thread James . Smart
> They are class devices called ttyS0, ttyS1, ttyS2 so you can say > they're uniquely named. > > The problem is that Matthew wants to add a symlink from the device > device to the class device to complement the class device to device > symlink, since we end up with multiple symlinks in the devices

Re: [PATCH] add transport class symlink to device object

2005-08-18 Thread Greg KH
On Thu, Aug 18, 2005 at 07:50:27AM +0100, Russell King wrote: > On Wed, Aug 17, 2005 at 11:41:29PM -0700, Greg KH wrote: > > On Thu, Aug 18, 2005 at 07:30:50AM +0100, Russell King wrote: > > > On Wed, Aug 17, 2005 at 10:21:56PM -0700, Greg KH wrote: > > > > On Mon, Aug 15, 2005 at 09:32:44AM +0100,

Re: [PATCH] add transport class symlink to device object

2005-08-17 Thread Russell King
On Wed, Aug 17, 2005 at 11:41:29PM -0700, Greg KH wrote: > On Thu, Aug 18, 2005 at 07:30:50AM +0100, Russell King wrote: > > On Wed, Aug 17, 2005 at 10:21:56PM -0700, Greg KH wrote: > > > On Mon, Aug 15, 2005 at 09:32:44AM +0100, Russell King wrote: > > > > On Mon, Aug 15, 2005 at 01:43:03AM +0100,

Re: [PATCH] add transport class symlink to device object

2005-08-17 Thread Greg KH
On Thu, Aug 18, 2005 at 07:30:50AM +0100, Russell King wrote: > On Wed, Aug 17, 2005 at 10:21:56PM -0700, Greg KH wrote: > > On Mon, Aug 15, 2005 at 09:32:44AM +0100, Russell King wrote: > > > On Mon, Aug 15, 2005 at 01:43:03AM +0100, Matthew Wilcox wrote: > > > > On Sun, Aug 14, 2005 at 11:25:25PM

Re: [PATCH] add transport class symlink to device object

2005-08-17 Thread Greg KH
On Wed, Aug 17, 2005 at 10:23:11PM -0700, Greg KH wrote: > On Mon, Aug 15, 2005 at 05:41:17PM -0500, James Bottomley wrote: > > Actually, isn't the fix to all of this to combine Greg and James' > > patches? > > Yes it is. > > > The Greg one fails in SCSI because we don't have unique class device

Re: [PATCH] add transport class symlink to device object

2005-08-17 Thread Russell King
On Wed, Aug 17, 2005 at 10:21:56PM -0700, Greg KH wrote: > On Mon, Aug 15, 2005 at 09:32:44AM +0100, Russell King wrote: > > On Mon, Aug 15, 2005 at 01:43:03AM +0100, Matthew Wilcox wrote: > > > On Sun, Aug 14, 2005 at 11:25:25PM +0100, Russell King wrote: > > > > Eww. Do you really want one struc

Re: [PATCH] add transport class symlink to device object

2005-08-17 Thread Greg KH
On Mon, Aug 15, 2005 at 09:32:44AM +0100, Russell King wrote: > On Mon, Aug 15, 2005 at 01:43:03AM +0100, Matthew Wilcox wrote: > > On Sun, Aug 14, 2005 at 11:25:25PM +0100, Russell King wrote: > > > Eww. Do you really want one struct device per tty with all the > > > memory each one eats? > > >

Re: [PATCH] add transport class symlink to device object

2005-08-17 Thread Greg KH
On Mon, Aug 15, 2005 at 05:41:17PM -0500, James Bottomley wrote: > On Sun, 2005-08-14 at 16:02 +0100, Matthew Wilcox wrote: > > /sys/class/tty/ttyS0/device -> > > ../../../devices/parisc/0/0:0/pci:00/:00:04.0 > > /sys/class/tty/ttyS1/device -> > > ../../../devices/parisc/0/0:0/pci:00/

Re: [PATCH] add transport class symlink to device object

2005-08-16 Thread Russell King
On Tue, Aug 16, 2005 at 09:37:18AM -0400, Luben Tuikov wrote: > On 08/15/05 20:52, [EMAIL PROTECTED] wrote: > > My vote is to make the multiplexor instantiate each serial line > > as a separate device. > > Yes, you're absolutely and completely correct. I think the same > way as you do. Just don'

RE: [PATCH] add transport class symlink to device object

2005-08-16 Thread James . Smart
> On Mon, 2005-08-15 at 20:52 -0400, [EMAIL PROTECTED] wrote: > > What is ":00:04:0" in this case ? The "device" is not a serial > > port, which is what the ttyXX back link would lead you to believe. > > Thus, it's a serial port multiplexer that supports up to N ports, > > right ? and wouldn't

Re: [PATCH] add transport class symlink to device object

2005-08-16 Thread Luben Tuikov
On 08/15/05 21:08, James Bottomley wrote: >>Think if SCSI used this same style of representation. For example, >>if there was no scsi target device entity, but class entities did >>exist and they just pointed back to the scsi host device entry. > > > Yes, it's theoretically possible to have had S

Re: [PATCH] add transport class symlink to device object

2005-08-16 Thread Luben Tuikov
On 08/15/05 20:52, [EMAIL PROTECTED] wrote: > Actually, I view this as being a little odd... > > What is ":00:04:0" in this case ? The "device" is not a serial > port, which is what the ttyXX back link would lead you to believe. > Thus, it's a serial port multiplexer that supports up to N port

RE: [PATCH] add transport class symlink to device object

2005-08-15 Thread James Bottomley
On Mon, 2005-08-15 at 20:52 -0400, [EMAIL PROTECTED] wrote: > What is ":00:04:0" in this case ? The "device" is not a serial > port, which is what the ttyXX back link would lead you to believe. > Thus, it's a serial port multiplexer that supports up to N ports, > right ? and wouldn't the more c

RE: [PATCH] add transport class symlink to device object

2005-08-15 Thread James . Smart
Actually, I view this as being a little odd... What is ":00:04:0" in this case ? The "device" is not a serial port, which is what the ttyXX back link would lead you to believe. Thus, it's a serial port multiplexer that supports up to N ports, right ? and wouldn't the more correct representatio

Re: [PATCH] add transport class symlink to device object

2005-08-15 Thread James Bottomley
On Sun, 2005-08-14 at 16:02 +0100, Matthew Wilcox wrote: > /sys/class/tty/ttyS0/device -> > ../../../devices/parisc/0/0:0/pci:00/:00:04.0 > /sys/class/tty/ttyS1/device -> > ../../../devices/parisc/0/0:0/pci:00/:00:04.0 > /sys/class/tty/ttyS2/device -> > ../../../devices/parisc/0/

Re: [PATCH] add transport class symlink to device object

2005-08-15 Thread Russell King
On Mon, Aug 15, 2005 at 01:43:03AM +0100, Matthew Wilcox wrote: > On Sun, Aug 14, 2005 at 11:25:25PM +0100, Russell King wrote: > > Eww. Do you really want one struct device per tty with all the > > memory each one eats? > > > > If that's really what you want you need to talk to Alan and not me.

Re: [PATCH] add transport class symlink to device object

2005-08-14 Thread Matthew Wilcox
On Sun, Aug 14, 2005 at 11:25:25PM +0100, Russell King wrote: > On Sun, Aug 14, 2005 at 04:02:31PM +0100, Matthew Wilcox wrote: > > Last time I tried to do something like this, it fell over with > > multi-function serial ports. Look at this example: > > > > # ls -l /sys/class/tty/ttyS*/device | c

Re: [PATCH] add transport class symlink to device object

2005-08-14 Thread Russell King
On Sun, Aug 14, 2005 at 04:02:31PM +0100, Matthew Wilcox wrote: > On Sat, Aug 13, 2005 at 02:39:56PM -0700, Greg KH wrote: > > Heh, I already have a patch like this pending for 2.6.14 at: > > > > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-01-driver/driver-link-devic

Re: [PATCH] add transport class symlink to device object

2005-08-14 Thread Matthew Wilcox
On Sat, Aug 13, 2005 at 02:39:56PM -0700, Greg KH wrote: > Heh, I already have a patch like this pending for 2.6.14 at: > > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-01-driver/driver-link-device-and-class.patch Last time I tried to do something like this, it fel