Re: [PATCH] advansys.c: include missing restore_flags, etc

2001-01-10 Thread Ralf Baechle
On Tue, Jan 09, 2001 at 08:30:07AM +0100, Pauline Middelink wrote: > > -STATIC int > > +STATIC unsigned long > > DvcEnterCritical(void) > > { > > -intflags; > > +unsigned long flags; > > > > save_flags(flags); > > cli(); > > @@ -9965,7 +9972,7 @@ > > } > > Err, accordi

Re: [PATCH] advansys.c: include missing restore_flags, etc

2001-01-09 Thread Pauline Middelink
On Tue, 09 Jan 2001 around 10:23:47 +, Alan Cox wrote: > > > save_flags(flags); > > > cli(); > > > @@ -9965,7 +9972,7 @@ > > > } > > > > Err, according tho wise ppl on this list, this does not work on > > MIPSes. The flags thing must stay in the same stackframe. > > Certainly does

Re: [PATCH] advansys.c: include missing restore_flags, etc

2001-01-09 Thread Arnaldo Carvalho de Melo
Em Tue, Jan 09, 2001 at 08:30:07AM +0100, Pauline Middelink escreveu: > > +STATIC unsigned long > > DvcEnterCritical(void) > > { > > -intflags; > > +unsigned long flags; > > > > save_flags(flags); > > cli(); > > @@ -9965,7 +9972,7 @@ > > } > > Err, according tho wise pp

Re: [PATCH] advansys.c: include missing restore_flags, etc

2001-01-09 Thread Russell King
Arnaldo Carvalho de Melo writes: > Please consider applying, comments in the patch. Can't the following be fixed properly? > -STATIC int > +STATIC unsigned long > DvcEnterCritical(void) > { > -intflags; > +unsigned long flags; > > save_flags(flags); > cli(); Gues

Re: [PATCH] advansys.c: include missing restore_flags, etc

2001-01-09 Thread Alan Cox
> > save_flags(flags); > > cli(); > > @@ -9965,7 +9972,7 @@ > > } > > Err, according tho wise ppl on this list, this does not work on > MIPSes. The flags thing must stay in the same stackframe. Certainly doesnt work on sparc32, but then it didnt before. Inline it might - To unsubscrib

Re: [PATCH] advansys.c: include missing restore_flags, etc

2001-01-08 Thread Pauline Middelink
On Tue, 09 Jan 2001 around 00:14:43 -0200, Arnaldo Carvalho de Melo wrote: > Hi, > > Please consider applying, comments in the patch. > > - Arnaldo > > > --- linux-2.4.0-ac4/drivers/scsi/advansys.c Mon Jan 8 20:39:28 2001 > +++ linux-2.4.0-ac4.acme/drivers/scsi/advansys.c Tue Jan

[PATCH] advansys.c: include missing restore_flags, etc

2001-01-08 Thread Arnaldo Carvalho de Melo
Hi, Please consider applying, comments in the patch. - Arnaldo --- linux-2.4.0-ac4/drivers/scsi/advansys.c Mon Jan 8 20:39:28 2001 +++ linux-2.4.0-ac4.acme/drivers/scsi/advansys.cTue Jan 9 00:12:03 2001 @@ -717,6 +717,13 @@ Ken Mort <[EMAIL PROTECTED]> reported a DE