Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-11 Thread David S. Miller
Date: Mon, 11 Sep 2000 11:56:12 -0300 From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Em Mon, Sep 11, 2000 at 08:35:59PM +0400, [EMAIL PROTECTED] escreveu: > It is a remnant of the past. Delete it here and in af_inet.c, > when you will send new patch to David. Here it is.

Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-11 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 11, 2000 at 08:35:59PM +0400, [EMAIL PROTECTED] escreveu: > Hello! > > > we need to set sk->dead to 1 before calling inet_sock_release in > > inet6_create? > > It is a remnant of the past. Delete it here and in af_inet.c, > when you will send new patch to David. > > Alexey Here it

Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-11 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 11, 2000 at 08:35:59PM +0400, [EMAIL PROTECTED] escreveu: Hello! we need to set sk-dead to 1 before calling inet_sock_release in inet6_create? It is a remnant of the past. Delete it here and in af_inet.c, when you will send new patch to David. Alexey Here it is.

Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-11 Thread David S. Miller
Date: Mon, 11 Sep 2000 11:56:12 -0300 From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Em Mon, Sep 11, 2000 at 08:35:59PM +0400, [EMAIL PROTECTED] escreveu: It is a remnant of the past. Delete it here and in af_inet.c, when you will send new patch to David. Here it is.

Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-10 Thread David S. Miller
Date: Sun, 10 Sep 2000 21:24:13 -0300 From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> What about the MOD_DEC_USE_COUNT and proc_net_create parts? Would you accept a patch for it? Send me the patch, redone without spurious code rearrangements, and then I'll give you an answer.

Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-10 Thread Arnaldo Carvalho de Melo
Em Sun, Sep 10, 2000 at 08:03:54PM -0700, David S. Miller escreveu: > > I'm not going to apply this patch. > > The goto's and "switch via if statements" are done for > better code generation, and your patch undoes this. Ok, I'll look harder in the future at the code generated. But then it'll

Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-10 Thread David S. Miller
I'm not going to apply this patch. The goto's and "switch via if statements" are done for better code generation, and your patch undoes this. Later, David S. Miller [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

[PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-10 Thread Arnaldo Carvalho de Melo
Hi, Please take a look and consider applying. One question: why we need to set sk->dead to 1 before calling inet_sock_release in inet6_create? sock_orphan does this for us and is called by inet_sock_release. - Arnaldo --- linux-2.4.0-test8/net/ipv6/af_inet6.c

[PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-10 Thread Arnaldo Carvalho de Melo
Hi, Please take a look and consider applying. One question: why we need to set sk-dead to 1 before calling inet_sock_release in inet6_create? sock_orphan does this for us and is called by inet_sock_release. - Arnaldo --- linux-2.4.0-test8/net/ipv6/af_inet6.c

Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-10 Thread David S. Miller
Date: Sun, 10 Sep 2000 21:24:13 -0300 From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] What about the MOD_DEC_USE_COUNT and proc_net_create parts? Would you accept a patch for it? Send me the patch, redone without spurious code rearrangements, and then I'll give you an answer. Once

Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-10 Thread David S. Miller
I'm not going to apply this patch. The goto's and "switch via if statements" are done for better code generation, and your patch undoes this. Later, David S. Miller [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH] af_ipv6.c: check proc_net_create and cleanups

2000-09-10 Thread Arnaldo Carvalho de Melo
Em Sun, Sep 10, 2000 at 08:03:54PM -0700, David S. Miller escreveu: I'm not going to apply this patch. The goto's and "switch via if statements" are done for better code generation, and your patch undoes this. Ok, I'll look harder in the future at the code generated. But then it'll be