RE: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread David Laight
> I'd encourage anyone thinking about "using OOB" to read > https://tools.ietf.org/html/rfc6093 first. Basically, TCP does not > actually provide an OOB mechanism, and frankly Unix sockets shouldn't > try either. OOB data maps much better onto ISO transport 'expedited data' than anything in a

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Shoaib Rao
On 1/29/21 1:18 PM, Jakub Kicinski wrote: On Fri, 29 Jan 2021 12:44:44 -0800 Shoaib Rao wrote: On 1/29/21 12:18 PM, Jakub Kicinski wrote: On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote: The code does not care about the size of data -- All it does is that if MSG_OOB is set it will

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Matthew Wilcox
On Fri, Jan 29, 2021 at 01:18:20PM -0800, Jakub Kicinski wrote: > On Fri, 29 Jan 2021 12:44:44 -0800 Shoaib Rao wrote: > > On 1/29/21 12:18 PM, Jakub Kicinski wrote: > > > On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote: > > >> The code does not care about the size of data -- All it does is

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 12:44:44 -0800 Shoaib Rao wrote: > On 1/29/21 12:18 PM, Jakub Kicinski wrote: > > On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote: > >> The code does not care about the size of data -- All it does is that if > >> MSG_OOB is set it will deliver the signal to the peer

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Shoaib Rao
On 1/29/21 12:44 PM, Shoaib Rao wrote: On 1/29/21 12:18 PM, Jakub Kicinski wrote: On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote: On 1/29/21 12:02 PM, Jakub Kicinski wrote: On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote: Data was discarded because the flag was not supported,

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Shoaib Rao
On 1/29/21 12:18 PM, Jakub Kicinski wrote: On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote: On 1/29/21 12:02 PM, Jakub Kicinski wrote: On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote: Data was discarded because the flag was not supported, this patch changes that but does not support

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 12:10:21 -0800 Shoaib Rao wrote: > On 1/29/21 12:02 PM, Jakub Kicinski wrote: > > On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote: > >> Data was discarded because the flag was not supported, this patch > >> changes that but does not support any urgent data. > > When you

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Shoaib Rao
On 1/29/21 12:02 PM, Jakub Kicinski wrote: On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote: SO_OOBINLINE does not control the delivery of signal, It controls how OOB Byte is delivered. It may not be obvious but this change does not deliver any Byte, just a signal. So, as long as sendmsg

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Shoaib Rao
On 1/29/21 11:54 AM, Shoaib Rao wrote: On 1/29/21 11:19 AM, Matthew Wilcox wrote: On Fri, Jan 29, 2021 at 09:56:48AM -0800, Shoaib Rao wrote: On 1/25/21 3:36 PM, Jakub Kicinski wrote: On Fri, 22 Jan 2021 15:06:37 + Matthew Wilcox (Oracle) wrote: From: Rao Shoaib TCP sockets allow

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 11:48:15 -0800 Shoaib Rao wrote: > >> SO_OOBINLINE does not control the delivery of signal, It controls how > >> OOB Byte is delivered. It may not be obvious but this change does not > >> deliver any Byte, just a signal. So, as long as sendmsg flag contains > >> MSG_OOB, signal

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Shoaib Rao
On 1/29/21 11:19 AM, Matthew Wilcox wrote: On Fri, Jan 29, 2021 at 09:56:48AM -0800, Shoaib Rao wrote: On 1/25/21 3:36 PM, Jakub Kicinski wrote: On Fri, 22 Jan 2021 15:06:37 + Matthew Wilcox (Oracle) wrote: From: Rao Shoaib TCP sockets allow SIGURG to be sent to the process holding

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Shoaib Rao
On 1/29/21 11:06 AM, Jakub Kicinski wrote: On Fri, 29 Jan 2021 09:56:48 -0800 Shoaib Rao wrote: On 1/25/21 3:36 PM, Jakub Kicinski wrote: On Fri, 22 Jan 2021 15:06:37 + Matthew Wilcox (Oracle) wrote: From: Rao Shoaib TCP sockets allow SIGURG to be sent to the process holding the other

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Matthew Wilcox
On Fri, Jan 29, 2021 at 09:56:48AM -0800, Shoaib Rao wrote: > On 1/25/21 3:36 PM, Jakub Kicinski wrote: > > On Fri, 22 Jan 2021 15:06:37 + Matthew Wilcox (Oracle) wrote: > > > From: Rao Shoaib > > > > > > TCP sockets allow SIGURG to be sent to the process holding the other > > > end of the

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 09:56:48 -0800 Shoaib Rao wrote: > On 1/25/21 3:36 PM, Jakub Kicinski wrote: > > On Fri, 22 Jan 2021 15:06:37 + Matthew Wilcox (Oracle) wrote: > >> From: Rao Shoaib > >> > >> TCP sockets allow SIGURG to be sent to the process holding the other > >> end of the socket.

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-29 Thread Shoaib Rao
On 1/25/21 3:36 PM, Jakub Kicinski wrote: On Fri, 22 Jan 2021 15:06:37 + Matthew Wilcox (Oracle) wrote: From: Rao Shoaib TCP sockets allow SIGURG to be sent to the process holding the other end of the socket. Extend Unix sockets to have the same ability. The API is the same in that

Re: [PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-25 Thread Jakub Kicinski
On Fri, 22 Jan 2021 15:06:37 + Matthew Wilcox (Oracle) wrote: > From: Rao Shoaib > > TCP sockets allow SIGURG to be sent to the process holding the other > end of the socket. Extend Unix sockets to have the same ability. > > The API is the same in that the sender uses sendmsg() with

[PATCH] af_unix: Allow Unix sockets to raise SIGURG

2021-01-22 Thread Matthew Wilcox (Oracle)
From: Rao Shoaib TCP sockets allow SIGURG to be sent to the process holding the other end of the socket. Extend Unix sockets to have the same ability. The API is the same in that the sender uses sendmsg() with MSG_OOB to raise SIGURG. Unix sockets behave in the same way as TCP sockets with