Re: [PATCH] afs: use correct format characters

2019-04-11 Thread Nick Desaulniers
On Thu, Apr 11, 2019 at 9:31 AM Linus Torvalds wrote: > > On Wed, Apr 10, 2019 at 4:01 PM Joe Perches wrote: > > > > I really think this clang message should be ignored. > > Agreed. > > > It's really unnecessary as every vararg argument smaller > > than int size is already promoted to int. > > Ex

Re: [PATCH] afs: use correct format characters

2019-04-11 Thread Linus Torvalds
On Wed, Apr 10, 2019 at 4:01 PM Joe Perches wrote: > > I really think this clang message should be ignored. Agreed. > It's really unnecessary as every vararg argument smaller > than int size is already promoted to int. Exactly. It's a pointless warning, making for more complex code, and making

Re: [PATCH] afs: use correct format characters

2019-04-10 Thread Joe Perches
On Wed, 2019-04-10 at 23:03 +0100, Louis Taylor wrote: > When compiling with -Wformat, clang warns: > > fs/afs/flock.c:632:29: warning: format specifies type 'short' but the > argument has type > 'unsigned char' [-Wformat] > _leave(" = %d [%hd]", ret, fl->fl_type); I really think t

Re: [PATCH] afs: use correct format characters

2019-04-10 Thread Nick Desaulniers
On Wed, Apr 10, 2019 at 3:03 PM Louis Taylor wrote: > > When compiling with -Wformat, clang warns: > > fs/afs/flock.c:632:29: warning: format specifies type 'short' but the > argument has type > 'unsigned char' [-Wformat] > _leave(" = %d [%hd]", ret, fl->fl_type); >

[PATCH] afs: use correct format characters

2019-04-10 Thread Louis Taylor
When compiling with -Wformat, clang warns: fs/afs/flock.c:632:29: warning: format specifies type 'short' but the argument has type 'unsigned char' [-Wformat] _leave(" = %d [%hd]", ret, fl->fl_type); ~~~ ^~~ fl_type is declared as an unsigned c