Re: [PATCH] aio: add aio_migratepage_helper to get rid of duplicate code

2014-02-10 Thread Rakesh Pandit
On Mon, Feb 10, 2014 at 11:24:02AM -0500, Benjamin LaHaise wrote: > On Mon, Feb 10, 2014 at 01:52:56PM +0200, Rakesh Pandit wrote: > > You're missing a commit message here providing justification for the changes > submitted. Why is this change a good thing? Did it fix any bugs? > It is minor

Re: [PATCH] aio: add aio_migratepage_helper to get rid of duplicate code

2014-02-10 Thread Benjamin LaHaise
On Mon, Feb 10, 2014 at 01:52:56PM +0200, Rakesh Pandit wrote: You're missing a commit message here providing justification for the changes submitted. Why is this change a good thing? Did it fix any bugs? -ben > Signed-off-by: Rakesh Pandit > --- > fs/aio.c | 55

[PATCH] aio: add aio_migratepage_helper to get rid of duplicate code

2014-02-10 Thread Rakesh Pandit
Signed-off-by: Rakesh Pandit --- fs/aio.c | 55 +++ 1 file changed, 23 insertions(+), 32 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index d3d55dc..20d690a 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -278,32 +278,46 @@ static int aio_set_page_dir