Re: [PATCH] amd-xgbe: remove h from printk format specifier

2020-12-23 Thread Joe Perches
On Wed, 2020-12-23 at 12:33 -0800, Tom Rix wrote: > On 12/23/20 12:14 PM, Joe Perches wrote: > > On Wed, 2020-12-23 at 11:43 -0800, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > This change fixes the checkpatch warning described in this commit > > > commit cbacb5ab0aa0 ("docs:

Re: [PATCH] amd-xgbe: remove h from printk format specifier

2020-12-23 Thread Tom Rix
On 12/23/20 12:14 PM, Joe Perches wrote: > On Wed, 2020-12-23 at 11:43 -0800, t...@redhat.com wrote: >> From: Tom Rix >> >> This change fixes the checkpatch warning described in this commit >> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of >> unnecessary %h[xudi] and

Re: [PATCH] amd-xgbe: remove h from printk format specifier

2020-12-23 Thread Joe Perches
On Wed, 2020-12-23 at 11:43 -0800, t...@redhat.com wrote: > From: Tom Rix > > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is already

[PATCH] amd-xgbe: remove h from printk format specifier

2020-12-23 Thread trix
From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of