Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-09 Thread John Johansen
On 4/9/19 1:55 PM, Kees Cook wrote: > On Tue, Apr 9, 2019 at 1:12 PM James Morris wrote: >> Actually, JJ usually submits directly to Linus. > > Ah! Right; I forgot. John, can you take and send this? > yep, I'll send it up today

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-09 Thread John Johansen
On 4/9/19 1:11 PM, James Morris wrote: > On Tue, 9 Apr 2019, Kees Cook wrote: > >> On Mon, Apr 8, 2019 at 11:21 PM David Rheinsberg >> wrote: >>> >>> Hi >>> >>> On Mon, Apr 8, 2019 at 6:07 PM Kees Cook wrote: Before commit c5459b829b71 ("LSM: Plumb visibility into optional "enabled" >>

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-09 Thread Kees Cook
On Tue, Apr 9, 2019 at 1:12 PM James Morris wrote: > Actually, JJ usually submits directly to Linus. Ah! Right; I forgot. John, can you take and send this? -- Kees Cook

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-09 Thread James Morris
On Tue, 9 Apr 2019, Kees Cook wrote: > On Mon, Apr 8, 2019 at 11:21 PM David Rheinsberg > wrote: > > > > Hi > > > > On Mon, Apr 8, 2019 at 6:07 PM Kees Cook wrote: > > > > > > Before commit c5459b829b71 ("LSM: Plumb visibility into optional "enabled" > > > state"), /sys/module/apparmor/parameter

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-09 Thread James Morris
On Tue, 9 Apr 2019, Kees Cook wrote: > On Mon, Apr 8, 2019 at 11:21 PM David Rheinsberg > wrote: > > > > Hi > > > > On Mon, Apr 8, 2019 at 6:07 PM Kees Cook wrote: > > > > > > Before commit c5459b829b71 ("LSM: Plumb visibility into optional "enabled" > > > state"), /sys/module/apparmor/parameter

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-09 Thread Kees Cook
On Mon, Apr 8, 2019 at 11:21 PM David Rheinsberg wrote: > > Hi > > On Mon, Apr 8, 2019 at 6:07 PM Kees Cook wrote: > > > > Before commit c5459b829b71 ("LSM: Plumb visibility into optional "enabled" > > state"), /sys/module/apparmor/parameters/enabled would show "Y" or "N" > > since it was using t

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-08 Thread David Rheinsberg
Hi On Mon, Apr 8, 2019 at 6:07 PM Kees Cook wrote: > > Before commit c5459b829b71 ("LSM: Plumb visibility into optional "enabled" > state"), /sys/module/apparmor/parameters/enabled would show "Y" or "N" > since it was using the "bool" handler. After being changed to "int", > this switched to "1"

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-08 Thread John Johansen
On 4/8/19 10:25 AM, Kees Cook wrote: > On Mon, Apr 8, 2019 at 9:58 AM John Johansen > wrote: >>> +/* Can only be set before AppArmor is initialized (i.e. on boot cmdline). >>> */ >>> +static int param_set_aaintbool(const char *val, const struct kernel_param >>> *kp) >>> +{ >>> + struct kerne

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-08 Thread Kees Cook
On Mon, Apr 8, 2019 at 9:58 AM John Johansen wrote: > > +/* Can only be set before AppArmor is initialized (i.e. on boot cmdline). > > */ > > +static int param_set_aaintbool(const char *val, const struct kernel_param > > *kp) > > +{ > > + struct kernel_param kp_local; > > + bool value; >

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-08 Thread John Johansen
On 4/8/19 9:07 AM, Kees Cook wrote: > Before commit c5459b829b71 ("LSM: Plumb visibility into optional "enabled" > state"), /sys/module/apparmor/parameters/enabled would show "Y" or "N" > since it was using the "bool" handler. After being changed to "int", > this switched to "1" or "0", breaking th

[PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-08 Thread Kees Cook
Before commit c5459b829b71 ("LSM: Plumb visibility into optional "enabled" state"), /sys/module/apparmor/parameters/enabled would show "Y" or "N" since it was using the "bool" handler. After being changed to "int", this switched to "1" or "0", breaking the userspace AppArmor detection of dbus-broke