Re: [PATCH] apparmor: remove unused label

2018-08-23 Thread Arnd Bergmann
On Thu, Aug 23, 2018 at 8:21 PM John Johansen wrote: > > On 08/23/2018 07:09 AM, Arnd Bergmann wrote: > > thank you for the patch, but a fix for this issue was pushed to apparmor-next > yesterday > Ok, good. As several people pointed out, my patch was also wrong, so that saves me doing another

Re: [PATCH] apparmor: remove unused label

2018-08-23 Thread Arnd Bergmann
On Thu, Aug 23, 2018 at 8:21 PM John Johansen wrote: > > On 08/23/2018 07:09 AM, Arnd Bergmann wrote: > > thank you for the patch, but a fix for this issue was pushed to apparmor-next > yesterday > Ok, good. As several people pointed out, my patch was also wrong, so that saves me doing another

Re: [PATCH] apparmor: remove unused label

2018-08-23 Thread John Johansen
On 08/23/2018 07:09 AM, Arnd Bergmann wrote: thank you for the patch, but a fix for this issue was pushed to apparmor-next yesterday > After the corresponding 'goto' was removed, we get a warning > for the 'fail' label: > > security/apparmor/policy_unpack.c: In function 'unpack_dfa': >

Re: [PATCH] apparmor: remove unused label

2018-08-23 Thread John Johansen
On 08/23/2018 07:09 AM, Arnd Bergmann wrote: thank you for the patch, but a fix for this issue was pushed to apparmor-next yesterday > After the corresponding 'goto' was removed, we get a warning > for the 'fail' label: > > security/apparmor/policy_unpack.c: In function 'unpack_dfa': >

Re: [PATCH] apparmor: remove unused label

2018-08-23 Thread Thiago Jung Bauermann
Arnd Bergmann writes: > After the corresponding 'goto' was removed, we get a warning > for the 'fail' label: > > security/apparmor/policy_unpack.c: In function 'unpack_dfa': > security/apparmor/policy_unpack.c:426:1: error: label 'fail' defined but not > used [-Werror=unused-label] > > Fixes:

Re: [PATCH] apparmor: remove unused label

2018-08-23 Thread Thiago Jung Bauermann
Arnd Bergmann writes: > After the corresponding 'goto' was removed, we get a warning > for the 'fail' label: > > security/apparmor/policy_unpack.c: In function 'unpack_dfa': > security/apparmor/policy_unpack.c:426:1: error: label 'fail' defined but not > used [-Werror=unused-label] > > Fixes:

Re: [PATCH] apparmor: remove unused label

2018-08-23 Thread Tetsuo Handa
On 2018/08/23 23:21, Kees Cook wrote: > On Thu, Aug 23, 2018 at 7:09 AM, Arnd Bergmann wrote: >> After the corresponding 'goto' was removed, we get a warning >> for the 'fail' label: >> >> security/apparmor/policy_unpack.c: In function 'unpack_dfa': >> security/apparmor/policy_unpack.c:426:1:

Re: [PATCH] apparmor: remove unused label

2018-08-23 Thread Tetsuo Handa
On 2018/08/23 23:21, Kees Cook wrote: > On Thu, Aug 23, 2018 at 7:09 AM, Arnd Bergmann wrote: >> After the corresponding 'goto' was removed, we get a warning >> for the 'fail' label: >> >> security/apparmor/policy_unpack.c: In function 'unpack_dfa': >> security/apparmor/policy_unpack.c:426:1:

Re: [PATCH] apparmor: remove unused label

2018-08-23 Thread Kees Cook
On Thu, Aug 23, 2018 at 7:09 AM, Arnd Bergmann wrote: > After the corresponding 'goto' was removed, we get a warning > for the 'fail' label: > > security/apparmor/policy_unpack.c: In function 'unpack_dfa': > security/apparmor/policy_unpack.c:426:1: error: label 'fail' defined but not > used

Re: [PATCH] apparmor: remove unused label

2018-08-23 Thread Kees Cook
On Thu, Aug 23, 2018 at 7:09 AM, Arnd Bergmann wrote: > After the corresponding 'goto' was removed, we get a warning > for the 'fail' label: > > security/apparmor/policy_unpack.c: In function 'unpack_dfa': > security/apparmor/policy_unpack.c:426:1: error: label 'fail' defined but not > used

[PATCH] apparmor: remove unused label

2018-08-23 Thread Arnd Bergmann
After the corresponding 'goto' was removed, we get a warning for the 'fail' label: security/apparmor/policy_unpack.c: In function 'unpack_dfa': security/apparmor/policy_unpack.c:426:1: error: label 'fail' defined but not used [-Werror=unused-label] Fixes: fb5841091f28 ("apparmor: remove no-op

[PATCH] apparmor: remove unused label

2018-08-23 Thread Arnd Bergmann
After the corresponding 'goto' was removed, we get a warning for the 'fail' label: security/apparmor/policy_unpack.c: In function 'unpack_dfa': security/apparmor/policy_unpack.c:426:1: error: label 'fail' defined but not used [-Werror=unused-label] Fixes: fb5841091f28 ("apparmor: remove no-op