Re: [PATCH] applesmc: Re-work SMC comms v1

2020-11-09 Thread kernel test robot
Hi Brad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hwmon/hwmon-next] [also build test WARNING on v5.10-rc3 next-20201109] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as docum

Re: [PATCH] applesmc: Re-work SMC comms v1

2020-11-04 Thread Guenter Roeck
On Thu, Nov 05, 2020 at 04:47:25PM +1100, Brad Campbell wrote: > Commit fff2d0f701e6 ("hwmon: (applesmc) avoid overlong udelay()") introduced > an issue whereby communication with the SMC became unreliable with write > errors : > > [ 120.378614] applesmc: send_byte(0x00, 0x0300) fail: 0x40 > [ 1

[PATCH] applesmc: Re-work SMC comms v1

2020-11-04 Thread Brad Campbell
Commit fff2d0f701e6 ("hwmon: (applesmc) avoid overlong udelay()") introduced an issue whereby communication with the SMC became unreliable with write errors : [ 120.378614] applesmc: send_byte(0x00, 0x0300) fail: 0x40 [ 120.378621] applesmc: LKSB: write data fail [ 120.512782] applesmc: send_by