Re: [PATCH] arch/sh/drivers/heartbeat.c ioremap is expected to succeed

2008-02-25 Thread Paul Mundt
On Mon, Feb 18, 2008 at 02:09:10PM +0100, Roel Kluin wrote: > !unlikely(hd->base) is equivalent to likely(!hd->base) (for instance see > comments with commit fd312561adcc90e924f35d3032d5493aeb4c3017), I think > the ioremap is expected to succeed? please confirm that's right. > The patch below was

Re: [PATCH] arch/sh/drivers/heartbeat.c ioremap is expected to succeed

2008-02-25 Thread Paul Mundt
On Mon, Feb 18, 2008 at 02:09:10PM +0100, Roel Kluin wrote: !unlikely(hd-base) is equivalent to likely(!hd-base) (for instance see comments with commit fd312561adcc90e924f35d3032d5493aeb4c3017), I think the ioremap is expected to succeed? please confirm that's right. The patch below was *not*

[PATCH] arch/sh/drivers/heartbeat.c ioremap is expected to succeed

2008-02-18 Thread Roel Kluin
!unlikely(hd->base) is equivalent to likely(!hd->base) (for instance see comments with commit fd312561adcc90e924f35d3032d5493aeb4c3017), I think the ioremap is expected to succeed? please confirm that's right. The patch below was *not* tested. --- ioremap is expected to succeed Signed-off-by:

[PATCH] arch/sh/drivers/heartbeat.c ioremap is expected to succeed

2008-02-18 Thread Roel Kluin
!unlikely(hd-base) is equivalent to likely(!hd-base) (for instance see comments with commit fd312561adcc90e924f35d3032d5493aeb4c3017), I think the ioremap is expected to succeed? please confirm that's right. The patch below was *not* tested. --- ioremap is expected to succeed Signed-off-by: Roel