Re: ***UNCHECKED*** Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-20 Thread dwalker
On Thu, Dec 18, 2014 at 11:35:04PM +0100, Arnd Bergmann wrote: > On Thursday 18 December 2014 22:01:28 dwal...@fifo99.com wrote: > > On Tue, Dec 16, 2014 at 12:20:43AM +0100, Rickard Strandqvist wrote: > > > Hi > > > > > > My script looks for the same function name, so if they then would be > > >

Re: ***UNCHECKED*** Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-20 Thread dwalker
On Thu, Dec 18, 2014 at 11:35:04PM +0100, Arnd Bergmann wrote: On Thursday 18 December 2014 22:01:28 dwal...@fifo99.com wrote: On Tue, Dec 16, 2014 at 12:20:43AM +0100, Rickard Strandqvist wrote: Hi My script looks for the same function name, so if they then would be named exactly

Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-18 Thread Arnd Bergmann
On Thursday 18 December 2014 22:01:28 dwal...@fifo99.com wrote: > On Tue, Dec 16, 2014 at 12:20:43AM +0100, Rickard Strandqvist wrote: > > Hi > > > > My script looks for the same function name, so if they then would be > > named exactly the same, they would come up. > > > > But I can not even

Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-18 Thread dwalker
On Tue, Dec 16, 2014 at 12:20:43AM +0100, Rickard Strandqvist wrote: > Hi > > My script looks for the same function name, so if they then would be > named exactly the same, they would come up. > > But I can not even find drivers/staging/dream/ or is this really new code? Maybe it was deleted

Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-18 Thread dwalker
On Tue, Dec 16, 2014 at 12:20:43AM +0100, Rickard Strandqvist wrote: Hi My script looks for the same function name, so if they then would be named exactly the same, they would come up. But I can not even find drivers/staging/dream/ or is this really new code? Maybe it was deleted

Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-18 Thread Arnd Bergmann
On Thursday 18 December 2014 22:01:28 dwal...@fifo99.com wrote: On Tue, Dec 16, 2014 at 12:20:43AM +0100, Rickard Strandqvist wrote: Hi My script looks for the same function name, so if they then would be named exactly the same, they would come up. But I can not even find

Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-15 Thread Rickard Strandqvist
Hi My script looks for the same function name, so if they then would be named exactly the same, they would come up. But I can not even find drivers/staging/dream/ or is this really new code? Kind regards Rickard Strandqvist 2014-12-09 15:46 GMT+01:00 : > > Seems ok to me. These files, and

Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-15 Thread Rickard Strandqvist
Hi My script looks for the same function name, so if they then would be named exactly the same, they would come up. But I can not even find drivers/staging/dream/ or is this really new code? Kind regards Rickard Strandqvist 2014-12-09 15:46 GMT+01:00 dwal...@fifo99.com: Seems ok to me.

Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-09 Thread dwalker
Seems ok to me. These files, and functions, are also in drivers/staging/dream/ are you removing them there also ? On Sun, Dec 07, 2014 at 02:12:20AM +0100, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > smsm_set_sleep_duration() smsm_get_state()

Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-09 Thread dwalker
Seems ok to me. These files, and functions, are also in drivers/staging/dream/ are you removing them there also ? On Sun, Dec 07, 2014 at 02:12:20AM +0100, Rickard Strandqvist wrote: Removes some functions that are not used anywhere: smsm_set_sleep_duration() smsm_get_state()

[PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-06 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: smsm_set_sleep_duration() smsm_get_state() smd_wait_until_writable() smd_wait_until_readable() smd_write_atomic() smd_sleep_exit() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard

[PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-06 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: smsm_set_sleep_duration() smsm_get_state() smd_wait_until_writable() smd_wait_until_readable() smd_write_atomic() smd_sleep_exit() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard