Re: [PATCH] arch: metag: mm: hugetlbpage.c: Cleaning up inconsistent NULL checks

2014-05-29 Thread Rickard Strandqvist
Hi First, I do not think we'll adapt the code as a static code checking to work! This must be resolved by other means. But yes, it is control where that gets cppcheck to react. And it is then also an unnecessary control. So then I guess it's ok to remove it. I resend a patch, with it removed. B

Re: [PATCH] arch: metag: mm: hugetlbpage.c: Cleaning up inconsistent NULL checks

2014-05-28 Thread James Hogan
Hi Rickard, On 22/05/14 23:01, Rickard Strandqvist wrote: > Cleaning up inconsistent NULL checks. > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > ar

[PATCH] arch: metag: mm: hugetlbpage.c: Cleaning up inconsistent NULL checks

2014-05-22 Thread Rickard Strandqvist
Cleaning up inconsistent NULL checks. There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/metag/mm/hugetlbpage.c |3 ++- 1 file changed, 2 insertions(+), 1 de