Re: [PATCH] arm/arm64: smccc: Use xN for arm64 register constraints with clang

2018-04-05 Thread Matthias Kaehlcke
On Thu, Apr 05, 2018 at 06:43:05PM +, Nick Desaulniers wrote: > On Thu, Mar 22, 2018 at 4:58 PM Matthias Kaehlcke wrote: > > > El Thu, Mar 22, 2018 at 04:19:42PM -0700 Greg Hackmann ha dit: > > > NAK. There's a reason I didn't send my change upstream. > > > > > > As Marc pointed out (https:/

Re: [PATCH] arm/arm64: smccc: Use xN for arm64 register constraints with clang

2018-04-05 Thread Nick Desaulniers
On Thu, Mar 22, 2018 at 4:58 PM Matthias Kaehlcke wrote: > El Thu, Mar 22, 2018 at 04:19:42PM -0700 Greg Hackmann ha dit: > > NAK. There's a reason I didn't send my change upstream. > > > > As Marc pointed out (https://lkml.org/lkml/2018/3/16/987), the "r" > > prefix tells gcc to pick the approp

Re: [PATCH] arm/arm64: smccc: Use xN for arm64 register constraints with clang

2018-03-22 Thread Matthias Kaehlcke
El Thu, Mar 22, 2018 at 04:19:42PM -0700 Greg Hackmann ha dit: > On 03/22/2018 03:44 PM, Matthias Kaehlcke wrote: > > El Thu, Mar 22, 2018 at 10:26:18PM + Nick Desaulniers ha dit: > > > >> Note that a patch in this form has previously been implemented by: > >> > >> Andrey Konovalov : > >> htt

Re: [PATCH] arm/arm64: smccc: Use xN for arm64 register constraints with clang

2018-03-22 Thread Greg Hackmann
On 03/22/2018 03:44 PM, Matthias Kaehlcke wrote: > El Thu, Mar 22, 2018 at 10:26:18PM + Nick Desaulniers ha dit: > >> Note that a patch in this form has previously been implemented by: >> >> Andrey Konovalov : >> https://gist.github.com/xairy/ee11682ea86044a45c0291c528cd936f >> >> and another

Re: [PATCH] arm/arm64: smccc: Use xN for arm64 register constraints with clang

2018-03-22 Thread Matthias Kaehlcke
El Thu, Mar 22, 2018 at 10:26:18PM + Nick Desaulniers ha dit: > Note that a patch in this form has previously been implemented by: > > Andrey Konovalov : > https://gist.github.com/xairy/ee11682ea86044a45c0291c528cd936f > > and another by: > > Greg Hackmann : > https://android-review.googles

Re: [PATCH] arm/arm64: smccc: Use xN for arm64 register constraints with clang

2018-03-22 Thread Nick Desaulniers
Note that a patch in this form has previously been implemented by: Andrey Konovalov : https://gist.github.com/xairy/ee11682ea86044a45c0291c528cd936f and another by: Greg Hackmann : https://android-review.googlesource.com/c/kernel/common/+/645181 If you used either as a reference, you may want t

[PATCH] arm/arm64: smccc: Use xN for arm64 register constraints with clang

2018-03-22 Thread Matthias Kaehlcke
The SMCCC v1.1 inline primitive code added by commit f2d3b2e8759a ("arm/arm64: smccc: Implement SMCCC v1.1 inline primitive") uses register names r0, r1, ... for constraints. This breaks clang builds for arm64, since clang currently only accepts x0, x1, ... in this context. Use xN names for registe