Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-17 Thread Sascha Hauer
On Mon, Feb 17, 2014 at 10:02:48AM +0100, Paul Bolle wrote: > On Mon, 2014-02-17 at 08:43 +0400, Alexander Shiyan wrote: > > It seems that even in the current state, Kconfig for i.MX contains an error. > > As a start, we should rename ARCH_MX1ADS to MACH_MX1ADS first. No. Have a look at

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-17 Thread Paul Bolle
On Mon, 2014-02-17 at 08:43 +0400, Alexander Shiyan wrote: > It seems that even in the current state, Kconfig for i.MX contains an error. > As a start, we should rename ARCH_MX1ADS to MACH_MX1ADS first. Last year I admitted that I didn't entirely grasped the differences between "arch",

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-17 Thread Paul Bolle
On Mon, 2014-02-17 at 08:43 +0400, Alexander Shiyan wrote: It seems that even in the current state, Kconfig for i.MX contains an error. As a start, we should rename ARCH_MX1ADS to MACH_MX1ADS first. Last year I admitted that I didn't entirely grasped the differences between arch, platform, and

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-17 Thread Sascha Hauer
On Mon, Feb 17, 2014 at 10:02:48AM +0100, Paul Bolle wrote: On Mon, 2014-02-17 at 08:43 +0400, Alexander Shiyan wrote: It seems that even in the current state, Kconfig for i.MX contains an error. As a start, we should rename ARCH_MX1ADS to MACH_MX1ADS first. No. Have a look at

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Alexander Shiyan
Воскресенье, 16 февраля 2014, 21:35 +01:00 от Paul Bolle : > On Sun, 2014-02-16 at 23:21 +0400, Alexander Shiyan wrote: > > Воскресенье, 16 февраля 2014, 20:12 +01:00 от Paul Bolle > : > > > On Sun, 2014-02-16 at 23:06 +0400, Alexander Shiyan wrote: > > > > Kconfig selects MACH_MXLADS, this

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Paul Bolle
On Sun, 2014-02-16 at 23:21 +0400, Alexander Shiyan wrote: > Воскресенье, 16 февраля 2014, 20:12 +01:00 от Paul Bolle : > > On Sun, 2014-02-16 at 23:06 +0400, Alexander Shiyan wrote: > > > Kconfig selects MACH_MXLADS, this enables machine_arch_type > > > from include/generated/mach-types.h which

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Alexander Shiyan
Воскресенье, 16 февраля 2014, 20:12 +01:00 от Paul Bolle : > On Sun, 2014-02-16 at 23:06 +0400, Alexander Shiyan wrote: > > Kconfig selects MACH_MXLADS, this enables machine_arch_type > > from include/generated/mach-types.h which used for machine_is_xx() macro, > > so if multiple boards is defined

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Paul Bolle
On Sun, 2014-02-16 at 23:06 +0400, Alexander Shiyan wrote: > Kconfig selects MACH_MXLADS, this enables machine_arch_type > from include/generated/mach-types.h which used for machine_is_xx() macro, > so if multiple boards is defined in the kernel, this cause to incorrect > matching. But, as I

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Alexander Shiyan
Воскресенье, 16 февраля 2014, 19:43 +01:00 от Paul Bolle : > On Sun, 2014-02-16 at 22:16 +0400, Alexander Shiyan wrote: > > Воскресенье, 16 февраля 2014, 19:03 +01:00 от Paul Bolle > : > > > The Kconfig symbol MACH_MXLADS was added in v2.6.29. It has never been > > > used. Setting it has no

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Paul Bolle
On Sun, 2014-02-16 at 22:16 +0400, Alexander Shiyan wrote: > Воскресенье, 16 февраля 2014, 19:03 +01:00 от Paul Bolle : > > The Kconfig symbol MACH_MXLADS was added in v2.6.29. It has never been > > used. Setting it has no effect. There are no calls for > > machine_is_mxlads(). This symbol can

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Alexander Shiyan
Воскресенье, 16 февраля 2014, 19:03 +01:00 от Paul Bolle : > The Kconfig symbol MACH_MXLADS was added in v2.6.29. It has never been > used. Setting it has no effect. There are no calls for > machine_is_mxlads(). This symbol can safely be removed. > > Signed-off-by: Paul Bolle This is used by

[PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Paul Bolle
The Kconfig symbol MACH_MXLADS was added in v2.6.29. It has never been used. Setting it has no effect. There are no calls for machine_is_mxlads(). This symbol can safely be removed. Signed-off-by: Paul Bolle --- Tested with "git grep". arch/arm/mach-imx/Kconfig | 4 1 file changed, 4

[PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Paul Bolle
The Kconfig symbol MACH_MXLADS was added in v2.6.29. It has never been used. Setting it has no effect. There are no calls for machine_is_mxlads(). This symbol can safely be removed. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Tested with git grep. arch/arm/mach-imx/Kconfig | 4 1 file

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Alexander Shiyan
Воскресенье, 16 февраля 2014, 19:03 +01:00 от Paul Bolle pebo...@tiscali.nl: The Kconfig symbol MACH_MXLADS was added in v2.6.29. It has never been used. Setting it has no effect. There are no calls for machine_is_mxlads(). This symbol can safely be removed. Signed-off-by: Paul Bolle

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Paul Bolle
On Sun, 2014-02-16 at 22:16 +0400, Alexander Shiyan wrote: Воскресенье, 16 февраля 2014, 19:03 +01:00 от Paul Bolle pebo...@tiscali.nl: The Kconfig symbol MACH_MXLADS was added in v2.6.29. It has never been used. Setting it has no effect. There are no calls for machine_is_mxlads(). This

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Alexander Shiyan
Воскресенье, 16 февраля 2014, 19:43 +01:00 от Paul Bolle pebo...@tiscali.nl: On Sun, 2014-02-16 at 22:16 +0400, Alexander Shiyan wrote: Воскресенье, 16 февраля 2014, 19:03 +01:00 от Paul Bolle pebo...@tiscali.nl: The Kconfig symbol MACH_MXLADS was added in v2.6.29. It has never been

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Paul Bolle
On Sun, 2014-02-16 at 23:06 +0400, Alexander Shiyan wrote: Kconfig selects MACH_MXLADS, this enables machine_arch_type from include/generated/mach-types.h which used for machine_is_xx() macro, so if multiple boards is defined in the kernel, this cause to incorrect matching. But, as I stated

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Alexander Shiyan
Воскресенье, 16 февраля 2014, 20:12 +01:00 от Paul Bolle pebo...@tiscali.nl: On Sun, 2014-02-16 at 23:06 +0400, Alexander Shiyan wrote: Kconfig selects MACH_MXLADS, this enables machine_arch_type from include/generated/mach-types.h which used for machine_is_xx() macro, so if multiple boards

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Paul Bolle
On Sun, 2014-02-16 at 23:21 +0400, Alexander Shiyan wrote: Воскресенье, 16 февраля 2014, 20:12 +01:00 от Paul Bolle pebo...@tiscali.nl: On Sun, 2014-02-16 at 23:06 +0400, Alexander Shiyan wrote: Kconfig selects MACH_MXLADS, this enables machine_arch_type from

Re: [PATCH] arm: imx: remove MACH_MXLADS

2014-02-16 Thread Alexander Shiyan
Воскресенье, 16 февраля 2014, 21:35 +01:00 от Paul Bolle pebo...@tiscali.nl: On Sun, 2014-02-16 at 23:21 +0400, Alexander Shiyan wrote: Воскресенье, 16 февраля 2014, 20:12 +01:00 от Paul Bolle pebo...@tiscali.nl: On Sun, 2014-02-16 at 23:06 +0400, Alexander Shiyan wrote: Kconfig selects