Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-12 Thread Russell King - ARM Linux admin
On Mon, Oct 12, 2020 at 12:03:18PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-10-11 22:32:38 [+0100], Russell King - ARM Linux admin wrote: > > I don't have a problem getting rid of the hex numbers in [< >] > > although then I will need to convert the symbol back to an address > > using the

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-12 Thread Sebastian Andrzej Siewior
On 2020-10-11 22:32:38 [+0100], Russell King - ARM Linux admin wrote: > I don't have a problem getting rid of the hex numbers in [< >] > although then I will need to convert the symbol back to an address > using the vmlinux to then calculate its address to then find the > appropriate place in the o

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-11 Thread Xiaoming Ni
On 2020/10/12 5:32, Russell King - ARM Linux admin wrote: On Fri, Oct 09, 2020 at 10:18:20AM +0200, Sebastian Andrzej Siewior wrote: On 2020-10-09 09:08:50 [+0100], Russell King - ARM Linux admin wrote: I am really not happy about this - it hurts at least my ability to debug the kernel when peo

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-11 Thread Russell King - ARM Linux admin
On Fri, Oct 09, 2020 at 10:18:20AM +0200, Sebastian Andrzej Siewior wrote: > On 2020-10-09 09:08:50 [+0100], Russell King - ARM Linux admin wrote: > > I am really not happy about this - it hurts at least my ability to > > debug the kernel when people post oopses to the mailing list. If > > people w

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-10 Thread Josh Poimboeuf
On Fri, Oct 09, 2020 at 09:08:50AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Oct 09, 2020 at 03:59:57PM +0800, Xiaoming Ni wrote: > > Printing raw pointer values in backtraces has potential security > > implications and are of questionable value anyway. > > > > This patch follows x86

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-09 Thread Xiaoming Ni
On 2020/10/9 16:18, Sebastian Andrzej Siewior wrote: On 2020-10-09 09:08:50 [+0100], Russell King - ARM Linux admin wrote: I am really not happy about this - it hurts at least my ability to debug the kernel when people post oopses to the mailing list. If In the reset scenario, dump_mem is reta

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-09 Thread Sebastian Andrzej Siewior
On 2020-10-09 09:08:50 [+0100], Russell King - ARM Linux admin wrote: > I am really not happy about this - it hurts at least my ability to > debug the kernel when people post oopses to the mailing list. If > people wish to make the kernel harder to debug, and are prepared > to be told "your kernel

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-09 Thread Russell King - ARM Linux admin
On Fri, Oct 09, 2020 at 03:59:57PM +0800, Xiaoming Ni wrote: > Printing raw pointer values in backtraces has potential security > implications and are of questionable value anyway. > > This patch follows x86 and arm64's lead and removes the "Exception stack:" > dump from kernel backtraces: >

[PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-09 Thread Xiaoming Ni
Printing raw pointer values in backtraces has potential security implications and are of questionable value anyway. This patch follows x86 and arm64's lead and removes the "Exception stack:" dump from kernel backtraces: commit a25ffd3a6302a6 ("arm64: traps: Don't print stack or raw