Re: Explicitly marking initializer overrides (was "Re: [PATCH] arm64/cache: silence -Woverride-init warnings")

2019-08-14 Thread Nathan Chancellor
On Fri, Aug 09, 2019 at 09:32:51AM +0100, Mark Rutland wrote: > On Thu, Aug 08, 2019 at 10:09:16AM -0700, Nathan Chancellor wrote: > > On Thu, Aug 08, 2019 at 11:38:08AM +0100, Mark Rutland wrote: > > > On Wed, Aug 07, 2019 at 11:29:16PM -0400, Qian Cai wrote: > > > > The commit 155433cb365e

Re: [PATCH] arm64/cache: silence -Woverride-init warnings

2019-08-09 Thread Nick Desaulniers
On Fri, Aug 9, 2019 at 1:53 AM Mark Rutland wrote: > * Find a mechanism to suppress the warning on a per-assignment (not > per-file) basis, without altering the structure of the existing code. #pragma push/pop can be used to suppress warnings in a localized section of a translation unit. --

Re: Explicitly marking initializer overrides (was "Re: [PATCH] arm64/cache: silence -Woverride-init warnings")

2019-08-09 Thread Robin Murphy
On 09/08/2019 09:32, Mark Rutland wrote: On Thu, Aug 08, 2019 at 10:09:16AM -0700, Nathan Chancellor wrote: On Thu, Aug 08, 2019 at 11:38:08AM +0100, Mark Rutland wrote: On Wed, Aug 07, 2019 at 11:29:16PM -0400, Qian Cai wrote: The commit 155433cb365e ("arm64: cache: Remove support for

Re: [PATCH] arm64/cache: silence -Woverride-init warnings

2019-08-09 Thread Will Deacon
On Thu, Aug 08, 2019 at 06:18:39PM -0400, Qian Cai wrote: > > On Aug 8, 2019, at 6:38 AM, Mark Rutland wrote: > > Please just turn this off by default for clang. > > As mentioned before, it is very valuable to run “make W=1” given it found > many real developer mistakes which will enable

Re: [PATCH] arm64/cache: silence -Woverride-init warnings

2019-08-09 Thread Mark Rutland
On Thu, Aug 08, 2019 at 06:18:39PM -0400, Qian Cai wrote: > > On Aug 8, 2019, at 6:38 AM, Mark Rutland wrote: > > > > On Wed, Aug 07, 2019 at 11:29:16PM -0400, Qian Cai wrote: > >> The commit 155433cb365e ("arm64: cache: Remove support for ASID-tagged > >> VIVT I-caches") introduced some

Explicitly marking initializer overrides (was "Re: [PATCH] arm64/cache: silence -Woverride-init warnings")

2019-08-09 Thread Mark Rutland
On Thu, Aug 08, 2019 at 10:09:16AM -0700, Nathan Chancellor wrote: > On Thu, Aug 08, 2019 at 11:38:08AM +0100, Mark Rutland wrote: > > On Wed, Aug 07, 2019 at 11:29:16PM -0400, Qian Cai wrote: > > > The commit 155433cb365e ("arm64: cache: Remove support for ASID-tagged > > > VIVT I-caches")

Re: [PATCH] arm64/cache: silence -Woverride-init warnings

2019-08-08 Thread Qian Cai
> On Aug 8, 2019, at 6:38 AM, Mark Rutland wrote: > > On Wed, Aug 07, 2019 at 11:29:16PM -0400, Qian Cai wrote: >> The commit 155433cb365e ("arm64: cache: Remove support for ASID-tagged >> VIVT I-caches") introduced some compiation warnings from GCC (and >> Clang) with

Re: [PATCH] arm64/cache: silence -Woverride-init warnings

2019-08-08 Thread Nathan Chancellor
On Thu, Aug 08, 2019 at 11:38:08AM +0100, Mark Rutland wrote: > On Wed, Aug 07, 2019 at 11:29:16PM -0400, Qian Cai wrote: > > The commit 155433cb365e ("arm64: cache: Remove support for ASID-tagged > > VIVT I-caches") introduced some compiation warnings from GCC (and > > Clang) with

Re: [PATCH] arm64/cache: silence -Woverride-init warnings

2019-08-08 Thread Mark Rutland
On Wed, Aug 07, 2019 at 11:29:16PM -0400, Qian Cai wrote: > The commit 155433cb365e ("arm64: cache: Remove support for ASID-tagged > VIVT I-caches") introduced some compiation warnings from GCC (and > Clang) with -Winitializer-overrides), > > arch/arm64/kernel/cpuinfo.c:38:26: warning:

Re: [PATCH] arm64/cache: silence -Woverride-init warnings

2019-08-07 Thread Nathan Chancellor
On Wed, Aug 07, 2019 at 11:29:16PM -0400, Qian Cai wrote: > The commit 155433cb365e ("arm64: cache: Remove support for ASID-tagged > VIVT I-caches") introduced some compiation warnings from GCC (and > Clang) with -Winitializer-overrides), > > arch/arm64/kernel/cpuinfo.c:38:26: warning:

[PATCH] arm64/cache: silence -Woverride-init warnings

2019-08-07 Thread Qian Cai
The commit 155433cb365e ("arm64: cache: Remove support for ASID-tagged VIVT I-caches") introduced some compiation warnings from GCC (and Clang) with -Winitializer-overrides), arch/arm64/kernel/cpuinfo.c:38:26: warning: initialized field overwritten [-Woverride-init] [ICACHE_POLICY_VIPT] =