Re: [PATCH] arm64/cpufeature: Convert hook_lock to raw_spin_lock_t in cpu_enable_ssbs()

2019-06-04 Thread Catalin Marinas
On Thu, May 30, 2019 at 12:30:58PM +0100, Julien Grall wrote: > cpu_enable_ssbs() is called via stop_machine() as part of the cpu_enable > callback. A spin lock is used to ensure the hook is registered before > the rest of the callback is executed. > > On -RT spin_lock() may sleep. However, all th

Re: [PATCH] arm64/cpufeature: Convert hook_lock to raw_spin_lock_t in cpu_enable_ssbs()

2019-05-30 Thread Julien Grall
Hi Will, On 5/30/19 1:01 PM, Will Deacon wrote: On Thu, May 30, 2019 at 12:30:58PM +0100, Julien Grall wrote: cpu_enable_ssbs() is called via stop_machine() as part of the cpu_enable callback. A spin lock is used to ensure the hook is registered before the rest of the callback is executed. On

Re: [PATCH] arm64/cpufeature: Convert hook_lock to raw_spin_lock_t in cpu_enable_ssbs()

2019-05-30 Thread Will Deacon
On Thu, May 30, 2019 at 12:30:58PM +0100, Julien Grall wrote: > cpu_enable_ssbs() is called via stop_machine() as part of the cpu_enable > callback. A spin lock is used to ensure the hook is registered before > the rest of the callback is executed. > > On -RT spin_lock() may sleep. However, all th

[PATCH] arm64/cpufeature: Convert hook_lock to raw_spin_lock_t in cpu_enable_ssbs()

2019-05-30 Thread Julien Grall
cpu_enable_ssbs() is called via stop_machine() as part of the cpu_enable callback. A spin lock is used to ensure the hook is registered before the rest of the callback is executed. On -RT spin_lock() may sleep. However, all the callees in stop_machine() are expected to not sleep. Therefore a raw_s