Re: [PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-26 Thread Catalin Marinas
On Mon, May 25, 2020 at 05:22:23AM +0530, Anshuman Khandual wrote: > On 05/21/2020 10:29 PM, Catalin Marinas wrote: > > On Thu, May 21, 2020 at 05:22:15PM +0100, Will Deacon wrote: > >> On Thu, May 21, 2020 at 08:45:38AM +0530, Anshuman Khandual wrote: > >>> The existing code has BUG_ON() in three

Re: [PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-24 Thread Anshuman Khandual
On 05/21/2020 10:29 PM, Catalin Marinas wrote: > On Thu, May 21, 2020 at 05:22:15PM +0100, Will Deacon wrote: >> On Thu, May 21, 2020 at 08:45:38AM +0530, Anshuman Khandual wrote: >>> On 05/20/2020 11:09 PM, Will Deacon wrote: On Wed, May 20, 2020 at 04:47:11PM +0100, Catalin Marinas wrote:

Re: [PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-21 Thread Catalin Marinas
On Thu, May 21, 2020 at 05:22:15PM +0100, Will Deacon wrote: > On Thu, May 21, 2020 at 08:45:38AM +0530, Anshuman Khandual wrote: > > On 05/20/2020 11:09 PM, Will Deacon wrote: > > > On Wed, May 20, 2020 at 04:47:11PM +0100, Catalin Marinas wrote: > > >> On Wed, May 20, 2020 at 01:20:13PM +0100, Wi

Re: [PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-21 Thread Will Deacon
On Thu, May 21, 2020 at 08:45:38AM +0530, Anshuman Khandual wrote: > > > On 05/20/2020 11:09 PM, Will Deacon wrote: > > On Wed, May 20, 2020 at 04:47:11PM +0100, Catalin Marinas wrote: > >> On Wed, May 20, 2020 at 01:20:13PM +0100, Will Deacon wrote: > >>> On Wed, May 20, 2020 at 06:52:54AM +0530

Re: [PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-20 Thread Anshuman Khandual
On 05/20/2020 11:09 PM, Will Deacon wrote: > On Wed, May 20, 2020 at 04:47:11PM +0100, Catalin Marinas wrote: >> On Wed, May 20, 2020 at 01:20:13PM +0100, Will Deacon wrote: >>> On Wed, May 20, 2020 at 06:52:54AM +0530, Anshuman Khandual wrote: There is no way to proceed when requested regi

Re: [PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-20 Thread Anshuman Khandual
On 05/20/2020 05:50 PM, Will Deacon wrote: > Hi Anshuman, > > On Wed, May 20, 2020 at 06:52:54AM +0530, Anshuman Khandual wrote: >> There is no way to proceed when requested register could not be searched in >> arm64_ftr_reg[]. Requesting for a non present register would be an error as >> well.

Re: [PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-20 Thread Will Deacon
On Wed, May 20, 2020 at 04:47:11PM +0100, Catalin Marinas wrote: > On Wed, May 20, 2020 at 01:20:13PM +0100, Will Deacon wrote: > > On Wed, May 20, 2020 at 06:52:54AM +0530, Anshuman Khandual wrote: > > > There is no way to proceed when requested register could not be searched > > > in > > > arm64

Re: [PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-20 Thread Catalin Marinas
On Wed, May 20, 2020 at 01:20:13PM +0100, Will Deacon wrote: > On Wed, May 20, 2020 at 06:52:54AM +0530, Anshuman Khandual wrote: > > There is no way to proceed when requested register could not be searched in > > arm64_ftr_reg[]. Requesting for a non present register would be an error as > > well.

Re: [PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-20 Thread Will Deacon
Hi Anshuman, On Wed, May 20, 2020 at 06:52:54AM +0530, Anshuman Khandual wrote: > There is no way to proceed when requested register could not be searched in > arm64_ftr_reg[]. Requesting for a non present register would be an error as > well. Hence lets just BUG_ON() when the search fails in get_

Re: [PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-20 Thread Catalin Marinas
On Wed, May 20, 2020 at 06:52:54AM +0530, Anshuman Khandual wrote: > There is no way to proceed when requested register could not be searched in > arm64_ftr_reg[]. Requesting for a non present register would be an error as > well. Hence lets just BUG_ON() when the search fails in get_arm64_ftr_reg(

[PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-19 Thread Anshuman Khandual
There is no way to proceed when requested register could not be searched in arm64_ftr_reg[]. Requesting for a non present register would be an error as well. Hence lets just BUG_ON() when the search fails in get_arm64_ftr_reg() rather than checking for return value and doing the same in some indivi