Re: [PATCH] arm64/mm: Remove add_huge_page_size()

2020-05-07 Thread Will Deacon
On Thu, May 07, 2020 at 10:15:59AM +1000, Gavin Shan wrote: > On 5/6/20 5:19 PM, Will Deacon wrote: > > On Wed, May 06, 2020 at 12:36:43PM +0530, Anshuman Khandual wrote: > > > > > > > > > On 05/06/2020 12:16 PM, Gavin Shan wrote: > > > > The function add_huge_page_size(), wrapper of hugetlb_add_

Re: [PATCH] arm64/mm: Remove add_huge_page_size()

2020-05-06 Thread Gavin Shan
On 5/6/20 5:19 PM, Will Deacon wrote: On Wed, May 06, 2020 at 12:36:43PM +0530, Anshuman Khandual wrote: On 05/06/2020 12:16 PM, Gavin Shan wrote: The function add_huge_page_size(), wrapper of hugetlb_add_hstate(), avoids to register duplicated huge page states for same size. However, the sam

Re: [PATCH] arm64/mm: Remove add_huge_page_size()

2020-05-06 Thread Will Deacon
On Wed, May 06, 2020 at 12:36:43PM +0530, Anshuman Khandual wrote: > > > On 05/06/2020 12:16 PM, Gavin Shan wrote: > > The function add_huge_page_size(), wrapper of hugetlb_add_hstate(), > > avoids to register duplicated huge page states for same size. However, > > the same logic has been include

Re: [PATCH] arm64/mm: Remove add_huge_page_size()

2020-05-06 Thread Anshuman Khandual
On 05/06/2020 12:16 PM, Gavin Shan wrote: > The function add_huge_page_size(), wrapper of hugetlb_add_hstate(), > avoids to register duplicated huge page states for same size. However, > the same logic has been included in hugetlb_add_hstate(). So it seems > unnecessary to keep add_huge_page_siz

[PATCH] arm64/mm: Remove add_huge_page_size()

2020-05-05 Thread Gavin Shan
The function add_huge_page_size(), wrapper of hugetlb_add_hstate(), avoids to register duplicated huge page states for same size. However, the same logic has been included in hugetlb_add_hstate(). So it seems unnecessary to keep add_huge_page_size() and this just removes it. Signed-off-by: Gavin S