Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-11-06 Thread Qian Cai
On Fri, 2020-11-06 at 10:37 +, Will Deacon wrote: > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > > index 09c96f57818c..10729d2d6084 100644 > > --- a/arch/arm64/kernel/smp.c > > +++ b/arch/arm64/kernel/smp.c > > @@ -421,6 +421,8 @@ void cpu_die_early(void) > > > >

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-11-06 Thread Will Deacon
On Thu, Nov 05, 2020 at 09:15:24PM -0500, Qian Cai wrote: > On Thu, 2020-11-05 at 15:28 -0800, Paul E. McKenney wrote: > > On Thu, Nov 05, 2020 at 06:02:49PM -0500, Qian Cai wrote: > > > On Thu, 2020-11-05 at 22:22 +, Will Deacon wrote: > > > > Hmm, this patch has caused a regression in the

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-11-05 Thread Paul E. McKenney
On Thu, Nov 05, 2020 at 09:15:24PM -0500, Qian Cai wrote: > On Thu, 2020-11-05 at 15:28 -0800, Paul E. McKenney wrote: > > On Thu, Nov 05, 2020 at 06:02:49PM -0500, Qian Cai wrote: > > > On Thu, 2020-11-05 at 22:22 +, Will Deacon wrote: > > > > On Fri, Oct 30, 2020 at 04:33:25PM +, Will

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-11-05 Thread Qian Cai
On Thu, 2020-11-05 at 15:28 -0800, Paul E. McKenney wrote: > On Thu, Nov 05, 2020 at 06:02:49PM -0500, Qian Cai wrote: > > On Thu, 2020-11-05 at 22:22 +, Will Deacon wrote: > > > On Fri, Oct 30, 2020 at 04:33:25PM +, Will Deacon wrote: > > > > On Wed, 28 Oct 2020 14:26:14 -0400, Qian Cai

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-11-05 Thread Paul E. McKenney
On Thu, Nov 05, 2020 at 06:02:49PM -0500, Qian Cai wrote: > On Thu, 2020-11-05 at 22:22 +, Will Deacon wrote: > > On Fri, Oct 30, 2020 at 04:33:25PM +, Will Deacon wrote: > > > On Wed, 28 Oct 2020 14:26:14 -0400, Qian Cai wrote: > > > > The call to rcu_cpu_starting() in

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-11-05 Thread Qian Cai
On Thu, 2020-11-05 at 22:22 +, Will Deacon wrote: > On Fri, Oct 30, 2020 at 04:33:25PM +, Will Deacon wrote: > > On Wed, 28 Oct 2020 14:26:14 -0400, Qian Cai wrote: > > > The call to rcu_cpu_starting() in secondary_start_kernel() is not early > > > enough in the CPU-hotplug onlining

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-11-05 Thread Will Deacon
On Fri, Oct 30, 2020 at 04:33:25PM +, Will Deacon wrote: > On Wed, 28 Oct 2020 14:26:14 -0400, Qian Cai wrote: > > The call to rcu_cpu_starting() in secondary_start_kernel() is not early > > enough in the CPU-hotplug onlining process, which results in lockdep > > splats as follows: > > > >

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-10-30 Thread Will Deacon
On Wed, 28 Oct 2020 14:26:14 -0400, Qian Cai wrote: > The call to rcu_cpu_starting() in secondary_start_kernel() is not early > enough in the CPU-hotplug onlining process, which results in lockdep > splats as follows: > > WARNING: suspicious RCU usage > - >

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-10-30 Thread Will Deacon
On Thu, Oct 29, 2020 at 09:17:35AM -0400, Qian Cai wrote: > On Thu, 2020-10-29 at 09:10 +, Will Deacon wrote: > > On Wed, Oct 28, 2020 at 02:26:14PM -0400, Qian Cai wrote: > > > The call to rcu_cpu_starting() in secondary_start_kernel() is not early > > > enough in the CPU-hotplug onlining

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-10-29 Thread Paul E. McKenney
On Thu, Oct 29, 2020 at 09:10:45AM +, Will Deacon wrote: > On Wed, Oct 28, 2020 at 02:26:14PM -0400, Qian Cai wrote: > > The call to rcu_cpu_starting() in secondary_start_kernel() is not early > > enough in the CPU-hotplug onlining process, which results in lockdep > > splats as follows: > >

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-10-29 Thread Qian Cai
On Thu, 2020-10-29 at 09:10 +, Will Deacon wrote: > On Wed, Oct 28, 2020 at 02:26:14PM -0400, Qian Cai wrote: > > The call to rcu_cpu_starting() in secondary_start_kernel() is not early > > enough in the CPU-hotplug onlining process, which results in lockdep > > splats as follows: > > > >

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-10-29 Thread Will Deacon
On Wed, Oct 28, 2020 at 02:26:14PM -0400, Qian Cai wrote: > The call to rcu_cpu_starting() in secondary_start_kernel() is not early > enough in the CPU-hotplug onlining process, which results in lockdep > splats as follows: > > WARNING: suspicious RCU usage > - >

[PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-10-28 Thread Qian Cai
The call to rcu_cpu_starting() in secondary_start_kernel() is not early enough in the CPU-hotplug onlining process, which results in lockdep splats as follows: WARNING: suspicious RCU usage - kernel/locking/lockdep.c:3497 RCU-list traversed in non-reader section!!

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-10-28 Thread Paul E. McKenney
On Wed, Oct 28, 2020 at 02:26:14PM -0400, Qian Cai wrote: > The call to rcu_cpu_starting() in secondary_start_kernel() is not early > enough in the CPU-hotplug onlining process, which results in lockdep > splats as follows: > > WARNING: suspicious RCU usage > - >