Re: [RESEND PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-06-30 Thread Thierry Reding
On Wed, Jun 29, 2016 at 01:21:53PM -0400, Rhyland Klein wrote: > Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and > the BA27XXX battery driver. These are all used on the Tegra210 Smaug > platform. > > Signed-off-by: Rhyland Klein > --- > > Resending as the issue with power_sup

Re: [RESEND PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-06-30 Thread Alexandre Courbot
On Thu, Jun 30, 2016 at 2:21 AM, Rhyland Klein wrote: > Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and > the BA27XXX battery driver. These are all used on the Tegra210 Smaug > platform. Tested-by: Alexandre Courbot Can see the bq27742 in /sys and query its state.

[RESEND PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-06-29 Thread Rhyland Klein
Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and the BA27XXX battery driver. These are all used on the Tegra210 Smaug platform. Signed-off-by: Rhyland Klein --- Resending as the issue with power_supply_core/bq27xxx_battery has been resolved. arch/arm64/configs/defconfig | 4

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-31 Thread Jon Hunter
On 27/05/16 13:55, Krzysztof Kozlowski wrote: > On 05/27/2016 02:17 PM, Jon Hunter wrote: >> >> On 27/05/16 12:46, Krzysztof Kozlowski wrote: >>> On 05/27/2016 12:28 PM, Jon Hunter wrote: Hi Krzysztof, On 27/05/16 09:37, Krzysztof Kozlowski wrote: ... > Indeed I w

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-27 Thread Krzysztof Kozlowski
On 05/27/2016 02:17 PM, Jon Hunter wrote: > > On 27/05/16 12:46, Krzysztof Kozlowski wrote: >> On 05/27/2016 12:28 PM, Jon Hunter wrote: >>> Hi Krzysztof, >>> >>> On 27/05/16 09:37, Krzysztof Kozlowski wrote: >>> >>> ... >>> Indeed I was struggling with similar issue in bq27x00_battery. The i

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-27 Thread Jon Hunter
On 27/05/16 12:46, Krzysztof Kozlowski wrote: > On 05/27/2016 12:28 PM, Jon Hunter wrote: >> Hi Krzysztof, >> >> On 27/05/16 09:37, Krzysztof Kozlowski wrote: >> >> ... >> >>> Indeed I was struggling with similar issue in bq27x00_battery. The issue >>> was introduced by... me :( when moving the o

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-27 Thread Krzysztof Kozlowski
On 05/27/2016 12:28 PM, Jon Hunter wrote: > Hi Krzysztof, > > On 27/05/16 09:37, Krzysztof Kozlowski wrote: > > ... > >> Indeed I was struggling with similar issue in bq27x00_battery. The issue >> was introduced by... me :( when moving the ownership of power supply >> structure from driver to t

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-27 Thread Jon Hunter
Hi Krzysztof, On 27/05/16 09:37, Krzysztof Kozlowski wrote: ... > Indeed I was struggling with similar issue in bq27x00_battery. The issue > was introduced by... me :( when moving the ownership of power supply > structure from driver to the core. However IMHO my change exposed the > fundamental

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-27 Thread Krzysztof Kozlowski
On 05/27/2016 10:37 AM, Krzysztof Kozlowski wrote: >> And you might be completely correct, that is something that can only >> happen specifically with the bq27xxx driver. In which case, making the >> fix there should be the fix. I just know from the commit log (and some >> previous work with power

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-27 Thread Krzysztof Kozlowski
On 05/25/2016 09:44 PM, Rhyland Klein wrote: > On 5/25/2016 1:26 PM, Jon Hunter wrote: >> >> On 25/05/16 17:36, Rhyland Klein wrote: >> >> ... >> >>> I can see that getting the temperature could work. I would point out >>> that I don't see any recent changes to bq27xxx or the power_supply_core >>>

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-26 Thread Jon Hunter
On 25/05/16 20:44, Rhyland Klein wrote: ... > And you might be completely correct, that is something that can only > happen specifically with the bq27xxx driver. In which case, making the > fix there should be the fix. I just know from the commit log (and some > previous work with power supply d

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 1:26 PM, Jon Hunter wrote: > > On 25/05/16 17:36, Rhyland Klein wrote: > > ... > >> I can see that getting the temperature could work. I would point out >> that I don't see any recent changes to bq27xxx or the power_supply_core >> that would imply this is a regression. My guess is t

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Jon Hunter
On 25/05/16 17:36, Rhyland Klein wrote: ... > I can see that getting the temperature could work. I would point out > that I don't see any recent changes to bq27xxx or the power_supply_core > that would imply this is a regression. My guess is that up until now, > for devices that support the TEMP

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Jon Hunter
On 25/05/16 17:29, Jon Hunter wrote: > > On 25/05/16 17:10, Jon Hunter wrote: > > ... > >> So power_supply_read_temp() calls ->get_property() and passes the >> power_supply psy struct which is initialised. The problem is that inside >> the bq27xxx driver, this then kicks off the worker thread t

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 12:29 PM, Jon Hunter wrote: > > On 25/05/16 17:10, Jon Hunter wrote: > > ... > >> So power_supply_read_temp() calls ->get_property() and passes the >> power_supply psy struct which is initialised. The problem is that inside >> the bq27xxx driver, this then kicks off the worker threa

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Jon Hunter
On 25/05/16 17:10, Jon Hunter wrote: ... > So power_supply_read_temp() calls ->get_property() and passes the > power_supply psy struct which is initialised. The problem is that inside > the bq27xxx driver, this then kicks off the worker thread to update the > bq27xxx state and when this worker t

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Jon Hunter
On 25/05/16 16:55, Rhyland Klein wrote: > On 5/25/2016 11:46 AM, Thierry Reding wrote: >> On Wed, May 25, 2016 at 12:03:47PM +0100, Jon Hunter wrote: >>> >>> On 25/05/16 11:58, Jon Hunter wrote: >>> >>> ... >>> Looking at this a bit more I am wondering if we should prevent the battery fo

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Jon Hunter
On 25/05/16 16:46, Thierry Reding wrote: ... > How about this, which should be the most minimal to fix it (though it's > completely untested) and still update the internal cache (it just won't > signal an supply change, which wouldn't work at this point anyway). The > patch makes up for the supp

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 11:46 AM, Thierry Reding wrote: > On Wed, May 25, 2016 at 12:03:47PM +0100, Jon Hunter wrote: >> >> On 25/05/16 11:58, Jon Hunter wrote: >> >> ... >> >>> Looking at this a bit more I am wondering if we should prevent the >>> battery for being polled before the registration has complete

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Rhyland Klein
On 5/25/2016 7:03 AM, Jon Hunter wrote: > > On 25/05/16 11:58, Jon Hunter wrote: > > ... I am aware of the splat, and I was considering the proper place for working around that. > >> Looking at this a bit more I am wondering if we should prevent the >> battery for being polled before the regis

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Thierry Reding
On Wed, May 25, 2016 at 12:03:47PM +0100, Jon Hunter wrote: > > On 25/05/16 11:58, Jon Hunter wrote: > > ... > > > Looking at this a bit more I am wondering if we should prevent the > > battery for being polled before the registration has completed ... > > > > diff --git a/drivers/power/bq27xxx

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Jon Hunter
On 25/05/16 11:58, Jon Hunter wrote: ... > Looking at this a bit more I am wondering if we should prevent the > battery for being polled before the registration has completed ... > > diff --git a/drivers/power/bq27xxx_battery.c > b/drivers/power/bq27xxx_battery.c > index 45f6ebf88df6..32649183e

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-25 Thread Jon Hunter
On 24/05/16 20:08, Rhyland Klein wrote: >> On 03/05/16 16:45, Rhyland Klein wrote: >>> Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and >>> the BA27XXX battery driver. These are all used on the Tegra210 Smaug >>> platform. >>> >>> Signed-off-by: Rhyland Klein >> >> I tried boot

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-24 Thread Rhyland Klein
On 5/24/2016 10:09 AM, Jon Hunter wrote: > Hi Rhyland, > > On 03/05/16 16:45, Rhyland Klein wrote: >> Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and >> the BA27XXX battery driver. These are all used on the Tegra210 Smaug >> platform. >> >> Signed-off-by: Rhyland Klein > > I

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-24 Thread Jon Hunter
Hi Rhyland, On 03/05/16 16:45, Rhyland Klein wrote: > Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and > the BA27XXX battery driver. These are all used on the Tegra210 Smaug > platform. > > Signed-off-by: Rhyland Klein I tried booting with this patch with next-20160523 on the

Re: [PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-19 Thread Rhyland Klein
On 5/3/2016 11:45 AM, Rhyland Klein wrote: > Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and > the BA27XXX battery driver. These are all used on the Tegra210 Smaug > platform. > > Signed-off-by: Rhyland Klein Has anyone had a chance to review this yet? -rhyland > --- > arc

[PATCH] arm64: defconfig: Enable cros-ec and battery driver

2016-05-03 Thread Rhyland Klein
Enable the ChromeOS Embedded Controller, its I2C tunnel driver, and the BA27XXX battery driver. These are all used on the Tegra210 Smaug platform. Signed-off-by: Rhyland Klein --- arch/arm64/configs/defconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/configs/defconfig b/