Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-06-04 Thread Luca Weiss
Hi Maxime, sorry I forgot to mark it as a v2 and add the changelog to v1. I've actually not split the patch into two on purpose as it's a pretty small change and the patch adding support for the A83T didn't split out the device tree changes - and recently in another patch of mine, the extra

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-06-04 Thread Maxime Ripard
Hi Luca, On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss You should have a changelog detailing which changes you made to your patch with the previous version, and why you made those changes (for example

[PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-06-04 Thread Luca Weiss
Add a node describing the KEYADC on the A64. Signed-off-by: Luca Weiss --- .../devicetree/bindings/input/sun4i-lradc-keys.txt| 1 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 2 files changed, 9 insertions(+) diff --git

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-06-04 Thread Maxime Ripard
On Mon, Jun 03, 2019 at 05:20:51PM +0200, Luca Weiss wrote: > On Montag, 3. Juni 2019 09:42:47 CEST Maxime Ripard wrote: > > Hi, > > > > On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > > > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > > It would be great to drop

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-06-03 Thread Luca Weiss
On Montag, 3. Juni 2019 09:42:47 CEST Maxime Ripard wrote: > Hi, > > On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > It would be great to drop the -keys from the compatible, and to > > > document the bindings > > >

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-06-03 Thread Maxime Ripard
Hi, On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > > It would be great to drop the -keys from the compatible, and to > > document the bindings > > > > Looks good otherwise > > > > Maxime > > So I should just document

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-31 Thread Luca Weiss
On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > It would be great to drop the -keys from the compatible, and to > document the bindings > > Looks good otherwise > > Maxime Hi again, So I should just document the "allwinner,sun50i-a64-lradc" string in

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-24 Thread Maxime Ripard
On Fri, May 24, 2019 at 10:35:36AM +0200, Luca Weiss wrote: > On Dienstag, 21. Mai 2019 16:25:44 CEST Maxime Ripard wrote: > > On Tue, May 21, 2019 at 03:52:47PM +0200, l...@z3ntu.xyz wrote: > > > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard > wrote: > > > >On Tue, May 21, 2019 at

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-24 Thread Luca Weiss
On Dienstag, 21. Mai 2019 16:25:44 CEST Maxime Ripard wrote: > On Tue, May 21, 2019 at 03:52:47PM +0200, l...@z3ntu.xyz wrote: > > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard wrote: > > >On Tue, May 21, 2019 at 08:43:45AM +0200, l...@z3ntu.xyz wrote: > > >> On May 20, 2019 1:07:42 PM

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-21 Thread Maxime Ripard
On Tue, May 21, 2019 at 03:52:47PM +0200, l...@z3ntu.xyz wrote: > On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard > wrote: > >On Tue, May 21, 2019 at 08:43:45AM +0200, l...@z3ntu.xyz wrote: > >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > wrote: > >> >On Sat, May 18, 2019 at

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-21 Thread luca
On May 21, 2019 3:09:55 PM GMT+02:00, Maxime Ripard wrote: >On Tue, May 21, 2019 at 08:43:45AM +0200, l...@z3ntu.xyz wrote: >> On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > wrote: >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: >> >> Add a node describing the KEYADC on

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-21 Thread Maxime Ripard
On Tue, May 21, 2019 at 08:43:45AM +0200, l...@z3ntu.xyz wrote: > On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > wrote: > >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > >> Add a node describing the KEYADC on the A64. > >> > >> Signed-off-by: Luca Weiss > >> --- > >>

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-21 Thread luca
On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard wrote: >Hi! > >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: >> Add a node describing the KEYADC on the A64. >> >> Signed-off-by: Luca Weiss >> --- >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++ >> 1 file changed,

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-20 Thread Maxime Ripard
Hi! On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > Add a node describing the KEYADC on the A64. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

[PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-18 Thread Luca Weiss
Add a node describing the KEYADC on the A64. Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index