Re: [PATCH] arm64: dts: ls1028a: fix optee node

2021-03-28 Thread Shawn Guo
On Mon, Mar 22, 2021 at 06:12:06PM -0500, Li Yang wrote: > On Thu, Mar 18, 2021 at 3:36 AM Michael Walle wrote: > > > > Don't enable the optee node in the SoC include. It is an optional > > component and actually, if enabled, breaks boards which doesn't have it. > > Hi Shawn, > > Shall we make t

Re: [PATCH] arm64: dts: ls1028a: fix optee node

2021-03-22 Thread Li Yang
On Thu, Mar 18, 2021 at 3:36 AM Michael Walle wrote: > > Don't enable the optee node in the SoC include. It is an optional > component and actually, if enabled, breaks boards which doesn't have it. Hi Shawn, Shall we make this a general rule? I see quite a few SoC dtsi files are having the opte

Re: [PATCH] arm64: dts: ls1028a: fix optee node

2021-03-22 Thread Michael Walle
Am 2021-03-22 14:04, schrieb Sahil Malhotra: Sahil, if you like you can pick it up to enable the nodes for your ls1028a boards. Michael, If we enable the optee node like this, will this gets resolved ? I don't know what you mean. This was a fix for the initial patch. So, I guess the answer is

Re: [PATCH] arm64: dts: ls1028a: fix optee node

2021-03-22 Thread Michael Walle
Hi Sahil, Am 2021-03-22 12:33, schrieb Sahil Malhotra: Thanks for the fix, and currently we support optee only on ls1028a-rdb boards. Does enabling the optee node this way, solves the issue ? What do you mean? Please note, that Shawn already reverted your commit. Therefore, I suggest you make

Re: [PATCH] arm64: dts: ls1028a: fix optee node

2021-03-18 Thread Michael Walle
Am 2021-03-18 09:34, schrieb Michael Walle: Don't enable the optee node in the SoC include. It is an optional component and actually, if enabled, breaks boards which doesn't have it. This reverts commit 48787485f8de ("arm64: dts: ls1028a: enable optee node") and enables the node per board, ass

[PATCH] arm64: dts: ls1028a: fix optee node

2021-03-18 Thread Michael Walle
Don't enable the optee node in the SoC include. It is an optional component and actually, if enabled, breaks boards which doesn't have it. This reverts commit 48787485f8de ("arm64: dts: ls1028a: enable optee node") and enables the node per board, assuming the intend of the original author was to e