Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-18 Thread Jerome Brunet
On Sat, 2019-01-19 at 02:09 +0800, Jianxin Pan wrote: > Hi Martin and Jerome, > > On 2019/1/18 5:20, Martin Blumenstingl wrote: > > On Thu, Jan 17, 2019 at 9:39 PM Jerome Brunet > > wrote: > > > On Thu, 2019-01-17 at 21:27 +0100, Martin Blumenstingl wrote: > > > > OK, but we had incorrect documen

Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-18 Thread Jianxin Pan
Hi Martin and Jerome, On 2019/1/18 5:20, Martin Blumenstingl wrote: > On Thu, Jan 17, 2019 at 9:39 PM Jerome Brunet wrote: >> >> On Thu, 2019-01-17 at 21:27 +0100, Martin Blumenstingl wrote: >>> OK, but we had incorrect documentation in the past. did you check this >>> with someone from Amlogic

Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-17 Thread Jerome Brunet
On Thu, 2019-01-17 at 23:42 +0100, Martin Blumenstingl wrote: > On Thu, Jan 17, 2019 at 10:45 PM Jerome Brunet wrote: > > On Thu, 2019-01-17 at 22:20 +0100, Martin Blumenstingl wrote: > > > On Thu, Jan 17, 2019 at 9:39 PM Jerome Brunet > > > wrote: > > > > On Thu, 2019-01-17 at 21:27 +0100, Marti

Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-17 Thread Martin Blumenstingl
On Thu, Jan 17, 2019 at 10:45 PM Jerome Brunet wrote: > > On Thu, 2019-01-17 at 22:20 +0100, Martin Blumenstingl wrote: > > On Thu, Jan 17, 2019 at 9:39 PM Jerome Brunet wrote: > > > On Thu, 2019-01-17 at 21:27 +0100, Martin Blumenstingl wrote: > > > > OK, but we had incorrect documentation in th

Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-17 Thread Jerome Brunet
On Thu, 2019-01-17 at 22:20 +0100, Martin Blumenstingl wrote: > On Thu, Jan 17, 2019 at 9:39 PM Jerome Brunet wrote: > > On Thu, 2019-01-17 at 21:27 +0100, Martin Blumenstingl wrote: > > > OK, but we had incorrect documentation in the past. did you check this > > > with someone from Amlogic? > > >

Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-17 Thread Martin Blumenstingl
On Thu, Jan 17, 2019 at 9:39 PM Jerome Brunet wrote: > > On Thu, 2019-01-17 at 21:27 +0100, Martin Blumenstingl wrote: > > OK, but we had incorrect documentation in the past. did you check this > > with someone from Amlogic? > > > > I'm curious because there seem to be two different approaches her

Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-17 Thread Jerome Brunet
On Thu, 2019-01-17 at 21:27 +0100, Martin Blumenstingl wrote: > OK, but we had incorrect documentation in the past. did you check this > with someone from Amlogic? > > I'm curious because there seem to be two different approaches here: > 1) hiubus name and offsets are being fixed within this patch

Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-17 Thread Martin Blumenstingl
Hi Jerome, On Thu, Jan 17, 2019 at 9:12 PM Jerome Brunet wrote: > > > On Thu, 2019-01-17 at 21:03 +0100, Martin Blumenstingl wrote: > > Hi Jerome, > > > > On Wed, Jan 16, 2019 at 5:52 PM Jerome Brunet wrote: > > [...] > > > - aobus: bus@ff80 { > > > - comp

Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-17 Thread Jerome Brunet
On Thu, 2019-01-17 at 21:03 +0100, Martin Blumenstingl wrote: > Hi Jerome, > > On Wed, Jan 16, 2019 at 5:52 PM Jerome Brunet wrote: > [...] > > - aobus: bus@ff80 { > > - compatible = "simple-bus"; > > - reg = <0x0 0xff80 0x0 0x10

Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-17 Thread Martin Blumenstingl
Hi Jerome, On Wed, Jan 16, 2019 at 5:52 PM Jerome Brunet wrote: [...] > - aobus: bus@ff80 { > - compatible = "simple-bus"; > - reg = <0x0 0xff80 0x0 0x10>; are you sure about removing aobus? in your patch "arm64: dts: meson: g1

Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-17 Thread Kevin Hilman
Jerome Brunet writes: > periph and hiu bus addresses/size are wrong. > cbus, aobus and apb just don't exist in the memory map so remove them. > > Fixes: 9c8c52f7cb4f ("arm64: dts: meson-g12a: add initial g12a s905d2 SoC DT > support") > Signed-off-by: Jerome Brunet Queued as a fix for v5.0-rc

Re: [PATCH] arm64: dts: meson: fix g12a buses

2019-01-17 Thread Kevin Hilman
Jerome Brunet writes: > periph and hiu bus addresses/size are wrong. > cbus, aobus and apb just don't exist in the memory map so remove them. > > Fixes: 9c8c52f7cb4f ("arm64: dts: meson-g12a: add initial g12a s905d2 SoC DT > support") > Signed-off-by: Jerome Brunet Queuing as a fix for v5.0-rc

[PATCH] arm64: dts: meson: fix g12a buses

2019-01-16 Thread Jerome Brunet
periph and hiu bus addresses/size are wrong. cbus, aobus and apb just don't exist in the memory map so remove them. Fixes: 9c8c52f7cb4f ("arm64: dts: meson-g12a: add initial g12a s905d2 SoC DT support") Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 70 +++---