Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-12 Thread Arnd Bergmann
On Mon, Jun 12, 2017 at 2:48 PM, Will Deacon wrote: > On Fri, Jun 09, 2017 at 08:57:31PM +0200, Arnd Bergmann wrote: >> On Fri, Jun 9, 2017 at 1:38 PM, Will Deacon wrote: >> > I can't seem to reproduce this simply by disabling MODULES in defconfig. >> >

Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-12 Thread Arnd Bergmann
On Mon, Jun 12, 2017 at 2:48 PM, Will Deacon wrote: > On Fri, Jun 09, 2017 at 08:57:31PM +0200, Arnd Bergmann wrote: >> On Fri, Jun 9, 2017 at 1:38 PM, Will Deacon wrote: >> > I can't seem to reproduce this simply by disabling MODULES in defconfig. >> > Could you share your .config, please? >>

Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-12 Thread Ard Biesheuvel
On 12 June 2017 at 14:48, Will Deacon wrote: > On Fri, Jun 09, 2017 at 08:57:31PM +0200, Arnd Bergmann wrote: >> On Fri, Jun 9, 2017 at 1:38 PM, Will Deacon wrote: >> > On Fri, Jun 09, 2017 at 12:27:06PM +0200, Arnd Bergmann wrote: >> >> When

Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-12 Thread Ard Biesheuvel
On 12 June 2017 at 14:48, Will Deacon wrote: > On Fri, Jun 09, 2017 at 08:57:31PM +0200, Arnd Bergmann wrote: >> On Fri, Jun 9, 2017 at 1:38 PM, Will Deacon wrote: >> > On Fri, Jun 09, 2017 at 12:27:06PM +0200, Arnd Bergmann wrote: >> >> When CONFIG_MODULES is disabled, we cannot dereference a

Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-12 Thread Will Deacon
On Fri, Jun 09, 2017 at 08:57:31PM +0200, Arnd Bergmann wrote: > On Fri, Jun 9, 2017 at 1:38 PM, Will Deacon wrote: > > On Fri, Jun 09, 2017 at 12:27:06PM +0200, Arnd Bergmann wrote: > >> When CONFIG_MODULES is disabled, we cannot dereference a module pointer: > >> > >>

Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-12 Thread Will Deacon
On Fri, Jun 09, 2017 at 08:57:31PM +0200, Arnd Bergmann wrote: > On Fri, Jun 9, 2017 at 1:38 PM, Will Deacon wrote: > > On Fri, Jun 09, 2017 at 12:27:06PM +0200, Arnd Bergmann wrote: > >> When CONFIG_MODULES is disabled, we cannot dereference a module pointer: > >> > >>

Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-09 Thread Arnd Bergmann
On Fri, Jun 9, 2017 at 1:38 PM, Will Deacon wrote: > Hi Arnd, > > On Fri, Jun 09, 2017 at 12:27:06PM +0200, Arnd Bergmann wrote: >> When CONFIG_MODULES is disabled, we cannot dereference a module pointer: >> >> arch/arm64/kernel/ftrace.c: In function 'ftrace_make_call': >>

Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-09 Thread Arnd Bergmann
On Fri, Jun 9, 2017 at 1:38 PM, Will Deacon wrote: > Hi Arnd, > > On Fri, Jun 09, 2017 at 12:27:06PM +0200, Arnd Bergmann wrote: >> When CONFIG_MODULES is disabled, we cannot dereference a module pointer: >> >> arch/arm64/kernel/ftrace.c: In function 'ftrace_make_call': >>

Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-09 Thread Will Deacon
Hi Arnd, On Fri, Jun 09, 2017 at 12:27:06PM +0200, Arnd Bergmann wrote: > When CONFIG_MODULES is disabled, we cannot dereference a module pointer: > > arch/arm64/kernel/ftrace.c: In function 'ftrace_make_call': > arch/arm64/kernel/ftrace.c:107:36: error: dereferencing pointer to incomplete >

Re: [PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-09 Thread Will Deacon
Hi Arnd, On Fri, Jun 09, 2017 at 12:27:06PM +0200, Arnd Bergmann wrote: > When CONFIG_MODULES is disabled, we cannot dereference a module pointer: > > arch/arm64/kernel/ftrace.c: In function 'ftrace_make_call': > arch/arm64/kernel/ftrace.c:107:36: error: dereferencing pointer to incomplete >

[PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-09 Thread Arnd Bergmann
When CONFIG_MODULES is disabled, we cannot dereference a module pointer: arch/arm64/kernel/ftrace.c: In function 'ftrace_make_call': arch/arm64/kernel/ftrace.c:107:36: error: dereferencing pointer to incomplete type 'struct module' trampoline = (unsigned long *)mod->arch.ftrace_trampoline;

[PATCH] arm64: ftrace: fix building without CONFIG_MODULES

2017-06-09 Thread Arnd Bergmann
When CONFIG_MODULES is disabled, we cannot dereference a module pointer: arch/arm64/kernel/ftrace.c: In function 'ftrace_make_call': arch/arm64/kernel/ftrace.c:107:36: error: dereferencing pointer to incomplete type 'struct module' trampoline = (unsigned long *)mod->arch.ftrace_trampoline;