Re: [PATCH] arm64: kaslr: Use standard early random function

2020-08-07 Thread Guenter Roeck
On 8/7/20 3:17 AM, Mark Rutland wrote: > Hi Guenter, > > On Thu, Aug 06, 2020 at 05:49:04PM -0700, Guenter Roeck wrote: >> Commit 585524081ecd ("random: random.h should include archrandom.h, not >> the other way around") tries to fix a problem with recursive inclusion >> of linux/random.h and

Re: [PATCH] arm64: kaslr: Use standard early random function

2020-08-07 Thread Mark Brown
On Thu, Aug 06, 2020 at 05:49:04PM -0700, Guenter Roeck wrote: > Use arch_get_random_seed_long_early() instead of arm64 specific functions > to solve the problem. As a side effect of this change, the code no longer > bypasses ARCH_RANDOM, which I consider desirable (after all, ARCH_RANDOM > was

Re: [PATCH] arm64: kaslr: Use standard early random function

2020-08-07 Thread Mark Rutland
Hi Guenter, On Thu, Aug 06, 2020 at 05:49:04PM -0700, Guenter Roeck wrote: > Commit 585524081ecd ("random: random.h should include archrandom.h, not > the other way around") tries to fix a problem with recursive inclusion > of linux/random.h and arch/archrandom.h for arm64. Unfortunately, this >

Re: [PATCH] arm64: kaslr: Use standard early random function

2020-08-06 Thread Linus Torvalds
On Thu, Aug 6, 2020 at 5:49 PM Guenter Roeck wrote: > > Use arch_get_random_seed_long_early() instead of arm64 specific functions > to solve the problem. As a side effect of this change, the code no longer > bypasses ARCH_RANDOM, which I consider desirable (after all, ARCH_RANDOM > was disabled

[PATCH] arm64: kaslr: Use standard early random function

2020-08-06 Thread Guenter Roeck
Commit 585524081ecd ("random: random.h should include archrandom.h, not the other way around") tries to fix a problem with recursive inclusion of linux/random.h and arch/archrandom.h for arm64. Unfortunately, this results in the following compile error if ARCH_RANDOM is disabled.